-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML: Fix search unnecessarily requiring source files #9129
Conversation
This seems to have been a mistake with sphinx-doc#4022 the ajax call functions correctly without the source files being included in the build (they are never used). I have tested this out on several themes and now everything works correctly with `html_copy_source = False`
I am not sure how to rebase this for 4.0.x but it would be nice if this could go into 4.0.x |
LGTM. Could you rebase this into the 4.x branch? |
This seems to have been a mistake with sphinx-doc#4022 the ajax call functions correctly without the source files being included in the build (they are never used). I have tested this out on several themes and now everything works correctly with `html_copy_source = False`
…x into Blendify/html-search-ajax
Merged manually.
You can do it with |
Thank you for your contribution as always :-) |
Subject: Fixes search summeries not showing when
html_copy_source = False
Bugfix
Purpose
This seems to have been a mistake with #4022 the ajax call functions correctly without the source files being included in the build (they are never used).
I have tested this out on several themes and now everything works correctly with
html_copy_source = False
Relates
#4022