Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pg): Pass through error if API response unexpected #1686

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

RPate97
Copy link
Collaborator

@RPate97 RPate97 commented Apr 18, 2024

Purpose

Causes API errors to be passed through to the console if the response code is unexpected. This should help with debugging API-related issues that are hard to reproduce.

Copy link
Collaborator

@sam-goldman sam-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the updated snippets contains invalid syntax, otherwise lgtm

throw new Error(
`Unexpected response code. Please report this to the developers.`
)
throw new e()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like invalid syntax

@RPate97 RPate97 force-pushed the pate/pass-through-response-code branch from e3accc3 to b54c683 Compare April 18, 2024 03:56
@RPate97 RPate97 merged commit 26ce8a3 into develop Apr 18, 2024
7 of 8 checks passed
@RPate97 RPate97 deleted the pate/pass-through-response-code branch April 18, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants