Fix some other coverage leaks

spicelang · Jul 10, 2023 · 947b86a · 947b86a
1 parent 848528d
commit 947b86a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/.run/spicetest.run.xml b/.run/spicetest.run.xml
@@ -1,5 +1,5 @@
 <component name="ProjectRunConfigurationManager">
-  <configuration default="false" name="spicetest" type="CMakeGoogleTestRunConfigurationType" factoryName="Google Test" PROGRAM_PARAMS="--update-refs=false" REDIRECT_INPUT="false" ELEVATE="false" USE_EXTERNAL_CONSOLE="false" PASS_PARENT_ENVS_2="true" PROJECT_NAME="Spice" TARGET_NAME="spicetest" CONFIG_NAME="Debug" RUN_TARGET_PROJECT_NAME="Spice" RUN_TARGET_NAME="spicetest" TEST_MODE="SUITE_TEST">
+  <configuration default="false" name="spicetest" type="CMakeGoogleTestRunConfigurationType" factoryName="Google Test" PROGRAM_PARAMS="--update-refs=false" REDIRECT_INPUT="false" ELEVATE="false" USE_EXTERNAL_CONSOLE="false" PASS_PARENT_ENVS_2="true" PROJECT_NAME="Spice" TARGET_NAME="spicetest" CONFIG_NAME="Debug" RUN_TARGET_PROJECT_NAME="Spice" RUN_TARGET_NAME="spicetest" TEST_CLASS="TypeCheckerTests" TEST_MODE="SUITE_TEST">
     <envs>
       <env name="RUN_TESTS" value="ON" />
       <env name="SPICE_STD_DIR" value="$PROJECT_DIR$/std" />

diff --git a/src/symboltablebuilder/SymbolTableEntry.cpp b/src/symboltablebuilder/SymbolTableEntry.cpp
@@ -40,8 +40,8 @@ void SymbolTableEntry::updateType(const SymbolType &newType, bool overwriteExist
 void SymbolTableEntry::updateState(const LifecycleState &newState, ASTNode *node, bool force) {
   const LifecycleState oldState = lifecycle.getCurrentState();
   // Check if this is a constant variable and is already initialized
-  if (newState != DEAD && oldState != DECLARED && type.isConst() && !force)
-    throw SemanticError(node, REASSIGN_CONST_VARIABLE, "Not re-assignable variable '" + name + "'");
+  if (newState != DEAD && oldState != DECLARED && type.isConst() && !force)                       // GCOV_EXCL_LINE
+    throw CompilerError(INTERNAL_ERROR, "Not re-assignable variable '" + name + "'");             // GCOV_EXCL_LINE
   if (newState == DEAD && oldState == DECLARED)                                                   // GCOV_EXCL_LINE
     throw CompilerError(INTERNAL_ERROR, "Cannot destruct uninitialized variable '" + name + "'"); // GCOV_EXCL_LINE
   if (newState == DEAD && oldState == DEAD)                                                       // GCOV_EXCL_LINE

diff --git a/src/visualizer/ASTVisualizer.cpp b/src/visualizer/ASTVisualizer.cpp
@@ -11,6 +11,6 @@ std::string ASTVisualizer::getSpaces() const {
   for (int i = 0; i < currentTabs; i++)
     spaces += " ";
   return spaces;
-}
+} // GCOVR_EXCL_LINE (false positive)
 
 } // namespace spice::compiler
diff --git a/test/test-files/typechecker/variables/error-reassign-const-var/exception.out b/test/test-files/typechecker/variables/error-reassign-const-var/exception.out
@@ -0,0 +1,5 @@
+[Error|Semantic] ./test-files/typechecker/variables/error-reassign-const-var/source.spice:3:5:
+Cannot re-assign constant variable: Trying to assign value to a constant
+
+3  i = 1234;
+     ^
diff --git a/test/test-files/typechecker/variables/error-reassign-const-var/source.spice b/test/test-files/typechecker/variables/error-reassign-const-var/source.spice
@@ -0,0 +1,4 @@
+f<int> main() {
+    const int i = 123;
+    i = 1234;
+}