Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error messages for out of range numeric literals #188

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

marcauberer
Copy link
Member

  • Add error message for out of range numeric literals
  • Add test for that
  • Refactor numeric parsing with negate operator

@marcauberer marcauberer added bug Something isn't working improvement Improvement of an existing feature labels Aug 22, 2022
@marcauberer marcauberer added this to the 0.11.0 milestone Aug 22, 2022
@marcauberer marcauberer self-assigned this Aug 22, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@52d2361). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 3202498 differs from pull request most recent head 5bbe1bc. Consider uploading reports for the commit 5bbe1bc to get more accurate results

@@          Coverage Diff          @@
##             main   #188   +/-   ##
=====================================
  Coverage        ?      0           
=====================================
  Files           ?      0           
  Lines           ?      0           
  Branches        ?      0           
=====================================
  Hits            ?      0           
  Misses          ?      0           
  Partials        ?      0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marcauberer marcauberer marked this pull request as ready for review August 23, 2022 07:36
@marcauberer marcauberer requested a review from a team as a code owner August 23, 2022 07:36
@marcauberer marcauberer merged commit 529c03a into main Aug 23, 2022
@marcauberer marcauberer deleted the fix/numeric-parsing branch August 23, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improvement of an existing feature size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants