Generate error messages lazily #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcauberer
commented
Jan 4, 2024
•
marcauberer
commented
- Generate error messages lazily. This improves compile time a lot, due to the fact that until now, for each ASTNode the error message was generated in advance (test run in CI from 1min 21s -> 44s). Furthermore, this should reduce the memory footprint on the heap (43MB -> 30MB).
- Fix memory leak due to non-virtual ASTNode destructor
marcauberer
force-pushed
the
feature/generate-error-msgs-lazily
branch
from
f9647a3
to
ec63d06
Compare
marcauberer
force-pushed
the
feature/generate-error-msgs-lazily
branch
from
ec63d06
to
5d24ab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.