Inline annotations #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspiano
reviewed
Aug 13, 2021
| @@ -575,6 +579,7 @@ abstract class ActionController::Base | |||
| {% unless name %} | |||
| {% name = "ws" + path.gsub(/\/|\-|\~|\*|\:|\./, "_") %} | |||
| {% end %} | |||
| private struct ANN__{{name.id}}; end | |||
|
Related: crystal-lang/crystal#9322 |
|
Closing in favour of c05553b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add supports for normal annotation semantics when marking up routes defined by macros.
Annotation a captured onto a throwaway type, then re-applied to the appropriate method when routes are drawn. As the original types are unused these will be dropped by the compiler.
Currently a limitation exists where the types of annotation need to be explicitly specified, however will continue searching for a solution to this. Until that is resolved, treat this as a proof of concept only.