Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove crd subnet/ippool deprecated property vlan default value #2576

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

Icarus9913
Copy link
Collaborator

Signed-off-by: Icarus9913 icaruswu66@qq.com

What type of PR is this?

new-feature, enhancement

What this PR does / why we need it:
remove crd subnet/ippool deprecated property vlan default value, so that I would not notice the vlan: 0 in the IPPool/Subnet resource

Which issue(s) this PR fixes:
close #2573

@Icarus9913 Icarus9913 added pr/ready-review This pull is ready for review release/feature-new release note for new feature labels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2576 (aa1037c) into main (5c3a444) will increase coverage by 0.50%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2576      +/-   ##
==========================================
+ Coverage   80.87%   81.38%   +0.50%     
==========================================
  Files          49       49              
  Lines        5303     5303              
==========================================
+ Hits         4289     4316      +27     
+ Misses        857      826      -31     
- Partials      157      161       +4     
Flag Coverage Δ
unittests 81.38% <100.00%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/subnetmanager/subnet_manager.go 41.48% <100.00%> (ø)

... and 2 files with indirect coverage changes

@Icarus9913 Icarus9913 force-pushed the feat/wk/crd-vlan-remove branch 2 times, most recently from 7e2f877 to fd5880d Compare November 8, 2023 13:38
Signed-off-by: Icarus9913 <icaruswu66@qq.com>
@Icarus9913 Icarus9913 closed this Nov 8, 2023
@Icarus9913 Icarus9913 reopened this Nov 8, 2023
@cyclinder cyclinder merged commit 0f94b2b into spidernet-io:main Nov 8, 2023
64 of 68 checks passed
@Icarus9913 Icarus9913 deleted the feat/wk/crd-vlan-remove branch December 14, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/ready-review This pull is ready for review release/feature-new release note for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove vlan in spiderippool
2 participants