fix update codegenerator scripts #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icarus9913
added
pr/ready-review
Icarus9913
force-pushed
the
fix/wk/code-generator
branch
from
d0a40fc
to
71d92ed
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3325 +/- ##
==========================================
- Coverage 81.68% 81.12% -0.56%
==========================================
Files 50 50
Lines 5372 5372
==========================================
- Hits 4388 4358 -30
- Misses 823 856 +33
+ Partials 161 158 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Icarus9913
force-pushed
the
fix/wk/code-generator
branch
from
71d92ed
to
88b88b5
Compare
Signed-off-by: Icarus9913 <icaruswu66@qq.com>
Icarus9913
force-pushed
the
fix/wk/code-generator
branch
from
88b88b5
to
0f5e89b
Compare
Icarus9913
temporarily deployed
to
release-base-images
GitHub Actions
Inactive
cyclinder
approved these changes
Mar 20, 2024
ty-dc
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v0.29.3 code-generator
kube_codegen.shuseto search CRD golang file, it will ignore the spiderpool CRD golang file because we define these CRD files with
***_types.goSo, I updated the code-generator to
v0.30.0-beta.0which would search.gofiles with+genclienttagsSigned-off-by: Icarus9913 icaruswu66@qq.com
What this PR does / why we need it:
fix bug
Which issue(s) this PR fixes:
close #3324