-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pod launched by unexpected CNI when the health checking of the agent fails and multus.conf is lost #3758
pod launched by unexpected CNI when the health checking of the agent fails and multus.conf is lost #3758
Conversation
currently, there is two containers in the pod, all debugging commands in the CI should change to |
{{- if .Values.multus.multusCNI.extraVolumes }} | ||
{{- include "tplvalues.render" ( dict "value" .Values.multus.multusCNI.extraVolumeMounts "context" $ ) | nindent 12 }} | ||
{{- end }} | ||
{{- end }} | ||
- name: {{ .Values.spiderpoolAgent.name | trunc 63 | trimSuffix "-" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it make a difference to do kubect logs
, if shifting this container as the first container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should make the agent's container as the first container.
a709cea
to
a0a4247
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3758 +/- ##
==========================================
- Coverage 81.68% 81.16% -0.53%
==========================================
Files 50 50
Lines 4391 4391
==========================================
- Hits 3587 3564 -23
- Misses 643 670 +27
+ Partials 161 157 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
a0a4247
to
7b11a50
Compare
7b11a50
to
aa4ff0a
Compare
test/Makefile
Outdated
@@ -382,6 +383,15 @@ uninstall_spiderpool: | |||
@echo -e "\033[35m [helm uninstall spiderpool] \033[0m" | |||
helm uninstall $(RELEASE_NAME) --wait --debug -n $(RELEASE_NAMESPACE) \ | |||
--kubeconfig $(E2E_KUBECONFIG) || { KIND_CLUSTER_NAME=$(E2E_CLUSTER_NAME) ./scripts/debugEnv.sh $(E2E_KUBECONFIG) "detail" ; exit 1 ; } ; \ | |||
NODE_LIST=` kind get nodes --name $(E2E_CLUSTER_NAME) `; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will rebase it after #3716 merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean these codes could be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
aa4ff0a
to
af7e26e
Compare
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
af7e26e
to
6dae80f
Compare
pod launched by unexpected CNI when the health checking of the agent fails and multus.conf is lost Signed-off-by: robot <tao.yang@daocloud.io>
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
the prestop of the agent's container would clean up the multus cni config(00-multus.conf), If the container restart but not pod restarts, the config file wouldn't be re-generated, which can cause the multus doesn't work.
the pr moves the multus-cni from init-container to container, and choose the it as the first containers.
Which issue(s) this PR fixes:
Fixes #3755
Special notes for your reviewer: