pod launched by unexpected CNI when the health checking of the agent fails and multus.conf is lost #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
added
release/bug
cherrypick-release-v0.8
weizhoublue
reviewed
Jul 25, 2024
|
currently, there is two containers in the pod, all debugging commands in the CI should change to |
weizhoublue
reviewed
Jul 25, 2024
| {{- if .Values.multus.multusCNI.extraVolumes }} | ||
| {{- include "tplvalues.render" ( dict "value" .Values.multus.multusCNI.extraVolumeMounts "context" $ ) | nindent 12 }} | ||
| {{- end }} | ||
| {{- end }} | ||
| - name: {{ .Values.spiderpoolAgent.name | trunc 63 | trimSuffix "-" }} |
There was a problem hiding this comment.
does it make a difference to do kubect logs , if shifting this container as the first container
There was a problem hiding this comment.
Yes, we should make the agent's container as the first container.
cyclinder
force-pushed
the
charts/multus_uninstall
branch
2 times, most recently
from
a709cea
to
a0a4247
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3758 +/- ##
==========================================
- Coverage 81.68% 81.16% -0.53%
==========================================
Files 50 50
Lines 4391 4391
==========================================
- Hits 3587 3564 -23
- Misses 643 670 +27
+ Partials 161 157 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
cyclinder
force-pushed
the
charts/multus_uninstall
branch
from
a0a4247
to
7b11a50
Compare
weizhoublue
changed the title
weizhoublue
previously approved these changes
Jul 26, 2024
cyclinder
force-pushed
the
charts/multus_uninstall
branch
from
7b11a50
to
aa4ff0a
Compare
weizhoublue
reviewed
Jul 26, 2024
test/Makefile
Outdated
| @@ -382,6 +383,15 @@ uninstall_spiderpool: | |||
| @echo -e "\033[35m [helm uninstall spiderpool] \033[0m" | |||
| helm uninstall $(RELEASE_NAME) --wait --debug -n $(RELEASE_NAMESPACE) \ | |||
| --kubeconfig $(E2E_KUBECONFIG) || { KIND_CLUSTER_NAME=$(E2E_CLUSTER_NAME) ./scripts/debugEnv.sh $(E2E_KUBECONFIG) "detail" ; exit 1 ; } ; \ | |||
| NODE_LIST=` kind get nodes --name $(E2E_CLUSTER_NAME) `; \ | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
ok, I will rebase it after #3716 merged.
There was a problem hiding this comment.
I mean these codes could be removed
weizhoublue
force-pushed
the
charts/multus_uninstall
branch
from
aa4ff0a
to
af7e26e
Compare
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
charts/multus_uninstall
branch
from
af7e26e
to
6dae80f
Compare
weizhoublue
changed the title
weizhoublue
approved these changes
Jul 31, 2024
This was referenced Jul 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
pod launched by unexpected CNI when the health checking of the agent fails and multus.conf is lost Signed-off-by: robot <tao.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
the prestop of the agent's container would clean up the multus cni config(00-multus.conf), If the container restart but not pod restarts, the config file wouldn't be re-generated, which can cause the multus doesn't work.
the pr moves the multus-cni from init-container to container, and choose the it as the first containers.
Which issue(s) this PR fixes:
Fixes #3755
Special notes for your reviewer: