-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coordinator: fix wrong policy route when there is more than 1 secondary nics #3873
coordinator: fix wrong policy route when there is more than 1 secondary nics #3873
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3873 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 51 51
Lines 4514 4514
=======================================
Hits 3649 3649
Misses 699 699
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. |
if err = netlink.RouteAdd(&route); err != nil && !os.IsExist(err) { | ||
logger.Error("failed to RouteAdd in new table ", zap.String("route", route.String()), zap.Error(err)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
route netlink.Route 进行 copy 修改,避免潜在 bug
相关日志也把 要生效的最终路由 打下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Can we add an issue? |
1de14e1
to
17b9a8c
Compare
17b9a8c
to
8d7fd70
Compare
need detailed description in the PR to explain the bug's influence , for release note |
8d7fd70
to
7989366
Compare
b550613
to
18d6279
Compare
相关 文档,提到了 pod 内
|
cmd/coordinator/cmd/utils.go
Outdated
return fmt.Errorf("when creating interface %s in underlay mode, it detects that the auxiliary interface %s was not created by previous interface. please enable coordinator plugin in previous interface", c.currentInterface, podFirstInterface) | ||
} | ||
|
||
// eth0, net1 ==> 101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些 comment 正式一点
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
c7b3cb1
to
fc2e500
Compare
788bf40
to
283cef7
Compare
wait for #3906 |
283cef7
to
e36ef5a
Compare
137e0c2
to
3957954
Compare
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
3957954
to
f52c78d
Compare
@@ -587,7 +587,7 @@ var _ = Describe("test ip with reclaim ip case", Label("reclaim"), func() { | |||
Expect(frame.DeletePod(podName, namespace)).To(Succeed(), "Failed to delete pod %v/%v\n", namespace, podName) | |||
GinkgoWriter.Printf("succeed to delete pod %v/%v\n", namespace, podName) | |||
}, | |||
Entry("a dirty IP record (pod name is wrong or containerID is wrong) in the IPPool should be auto clean by Spiderpool", Serial, Label("G00005", "G00007")), | |||
PEntry("a dirty IP record (pod name is wrong or containerID is wrong) in the IPPool should be auto clean by Spiderpool", Serial, Label("G00005", "G00007")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ty-dc 该ci是否已修复? 后续打开
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3926 中打开
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3877
Special notes for your reviewer: