coordinator: fix wrong policy route when there is more than 1 secondary nics #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
added
release/bug
cherrypick-release-v0.9
cherrypick-release-v1.0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3873 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 51 51
Lines 4514 4514
=======================================
Hits 3649 3649
Misses 699 699
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. |
weizhoublue
reviewed
Aug 12, 2024
| if err = netlink.RouteAdd(&route); err != nil && !os.IsExist(err) { | ||
| logger.Error("failed to RouteAdd in new table ", zap.String("route", route.String()), zap.Error(err)) |
There was a problem hiding this comment.
route netlink.Route 进行 copy 修改，避免潜在 bug
相关日志也把 要生效的最终路由 打下
|
Can we add an issue? |
cyclinder
force-pushed
the
coordinator/tune_pod_route
branch
from
1de14e1
to
17b9a8c
Compare
cyclinder
force-pushed
the
coordinator/tune_pod_route
branch
from
17b9a8c
to
8d7fd70
Compare
weizhoublue
changed the title
|
need detailed description in the PR to explain the bug's influence , for release note |
cyclinder
force-pushed
the
coordinator/tune_pod_route
branch
from
8d7fd70
to
7989366
Compare
weizhoublue
changed the title
weizhoublue
changed the title
cyclinder
force-pushed
the
coordinator/tune_pod_route
branch
3 times, most recently
from
b550613
to
18d6279
Compare
|
相关 文档，提到了 pod 内 |
weizhoublue
reviewed
Aug 15, 2024
cmd/coordinator/cmd/utils.go
Outdated
| return fmt.Errorf("when creating interface %s in underlay mode, it detects that the auxiliary interface %s was not created by previous interface. please enable coordinator plugin in previous interface", c.currentInterface, podFirstInterface) | ||
| } | ||
|
|
||
| // eth0, net1 ==> 101 |
cyclinder
force-pushed
the
coordinator/tune_pod_route
branch
7 times, most recently
from
c7b3cb1
to
fc2e500
Compare
cyclinder
force-pushed
the
coordinator/tune_pod_route
branch
9 times, most recently
from
788bf40
to
283cef7
Compare
|
wait for #3906 |
cyclinder
force-pushed
the
coordinator/tune_pod_route
branch
from
283cef7
to
e36ef5a
Compare
cyclinder
force-pushed
the
coordinator/tune_pod_route
branch
7 times, most recently
from
137e0c2
to
3957954
Compare
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
coordinator/tune_pod_route
branch
from
3957954
to
f52c78d
Compare
ty-dc
approved these changes
Aug 26, 2024
weizhoublue
approved these changes
Aug 26, 2024
| @@ -587,7 +587,7 @@ var _ = Describe("test ip with reclaim ip case", Label("reclaim"), func() { | |||
| Expect(frame.DeletePod(podName, namespace)).To(Succeed(), "Failed to delete pod %v/%v\n", namespace, podName) | |||
| GinkgoWriter.Printf("succeed to delete pod %v/%v\n", namespace, podName) | |||
| }, | |||
| Entry("a dirty IP record (pod name is wrong or containerID is wrong) in the IPPool should be auto clean by Spiderpool", Serial, Label("G00005", "G00007")), | |||
| PEntry("a dirty IP record (pod name is wrong or containerID is wrong) in the IPPool should be auto clean by Spiderpool", Serial, Label("G00005", "G00007")), | |||
There was a problem hiding this comment.
@ty-dc 该ci是否已修复？ 后续打开
This was referenced Aug 26, 2024
cyclinder
added
the
cherrypick-release-v0.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3877
Special notes for your reviewer: