rbac: remove permissions for patch/update nodes and webhook resources #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3880 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 50 50
Lines 4391 4391
=======================================
Hits 3564 3564
Misses 670 670
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
|
@cyclinder Thanks! You can just pull this code, I will review it in about one hour:) |
|
@cyclinder Am I the reviewer of the PR? I notice that the Merging is blocked and I am a participant, but where can I help you to approve it? |
|
@weizhoublue Please review this PR, thanks a lot:) |
cyclinder
added
cherrypick-release-v0.9
cherrypick-release-v1.0
weizhoublue
approved these changes
Aug 14, 2024
This was referenced Aug 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
rbac: remove permissions for patch/update nodes and webhook resources Signed-off-by: robot <tao.yang@daocloud.io>
|
@cyclinder Please refer to your mailbox, I send another message to you privately:) |
This was referenced Aug 27, 2024
The delete permission in rbac was removed, causing the automatic deletion of webhooks to fail.
#3958
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: