Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Spiderpool GC incorrect IP address during statefulset Pod scale up/down, causing IP conflict #3902

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

weizhoublue
Copy link
Collaborator

robot cherry pick PR #3778 from ty-dc,to branch release-v1.0, action https://github.com/spidernet-io/spiderpool/actions/runs/10454536885 , commits a5a29e1

fix: Spiderpool GC incorrect IP address during statefulset Pod scale up/down, causing IP conflict
Signed-off-by: robot <tao.yang@daocloud.io>
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (ac18f55) to head (0fe1c88).
Report is 4 commits behind head on release-v1.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v1.0    #3902      +/-   ##
================================================
+ Coverage         81.16%   81.28%   +0.11%     
================================================
  Files                50       50              
  Lines              4391     4408      +17     
================================================
+ Hits               3564     3583      +19     
+ Misses              670      669       -1     
+ Partials            157      156       -1     
Flag Coverage Δ
unittests 81.28% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...orkloadendpointmanager/workloadendpoint_manager.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@weizhoublue
Copy link
Collaborator Author

https://github.com/spidernet-io/spiderpool/actions/runs/10454544226/job/28947765944?pr=3902

Summarizing 1 Failure:
  [FAIL] test reliability reliability test table [It] Successfully run a pod during the coreDns is restarting [reliability, R00005]
  /home/runner/work/spiderpool/spiderpool/test/e2e/reliability/reliability_test.go:69

@ty-dc ty-dc closed this Aug 21, 2024
@ty-dc ty-dc reopened this Aug 21, 2024
@weizhoublue
Copy link
Collaborator Author

weizhoublue commented Aug 21, 2024

https://github.com/spidernet-io/spiderpool/actions/runs/10454544226/job/28947765944?pr=3902

Summarizing 1 Failure:
  [FAIL] test reliability reliability test table [It] Successfully run a pod during the coreDns is restarting [reliability, R00005]
  /home/runner/work/spiderpool/spiderpool/test/e2e/reliability/reliability_test.go:69

debug this, open an issue if necessary

@ty-dc
Copy link
Collaborator

ty-dc commented Aug 21, 2024

https://github.com/spidernet-io/spiderpool/actions/runs/10454544226/job/28947765944?pr=3902

Summarizing 1 Failure:
  [FAIL] test reliability reliability test table [It] Successfully run a pod during the coreDns is restarting [reliability, R00005]
  /home/runner/work/spiderpool/spiderpool/test/e2e/reliability/reliability_test.go:69

debug this, open an issue if necessary

yes, in progress

@weizhoublue weizhoublue merged commit 099ca3d into release-v1.0 Aug 22, 2024
103 of 105 checks passed
@weizhoublue weizhoublue deleted the robot/cherrypick/pr3778/release-v1.0 branch August 22, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants