Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(all): Change npm commands since yarn is the default package manager #204

Merged
merged 2 commits into from
Dec 24, 2023

Conversation

carlos-ds
Copy link
Collaborator

@carlos-ds carlos-ds commented Dec 21, 2023

@spierala I didn't change (or add to) any of the npm commands for users installing (dependencies related to) mini-rx-store, because I assume that was not in scope. If it would be, let me know and I could add the yarn commands next to the npm ones.

@spierala
Copy link
Owner

@spierala I didn't change (or add to) any of the npm commands for users installing (dependencies related to) mini-rx-store, because I assume that was not in scope. If it would be, let me know and I could add the yarn commands next to the npm ones.

Thanks @carlos-ds for the PR.

Installing mini-rx-store via npm is still a good default.
Advanced users will hopefully know that they can also use yarn to install mini-rx-store :)

package.json Outdated Show resolved Hide resolved
@spierala spierala mentioned this pull request Dec 22, 2023
Co-authored-by: Florian Spier <mail@florian-spier.de>
@carlos-ds carlos-ds force-pushed the refactor/change-npm-references branch from 48cb332 to 7e03ff3 Compare December 24, 2023 09:32
@spierala spierala merged commit 4a91e79 into spierala:master Dec 24, 2023
1 check passed
@spierala
Copy link
Owner

@all-contributors please add @carlos-ds for code, review

Copy link
Contributor

@spierala

I've put up a pull request to add @carlos-ds! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants