Fix JoinPathSegments to disallow dot segments #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
force-pushed
the
fix-join-path-segments
branch
from
4c1a1e5 to
364a7c5
Compare
JoinPathSegments does not fail for dot segments but should. This PR also exports ValidatePathSegment for convenience. Signed-off-by: Andrew Harding <andrew@spirl.com>
azdagron
force-pushed
the
fix-join-path-segments
branch
from
364a7c5 to
123dc6b
Compare
MarcosDY
reviewed
Mar 16, 2023
| // ValidatePathSegment validates that a string is a conformant segment for | ||
| // inclusion in the path for a SPIFFE ID. | ||
| // See https://github.com/spiffe/spiffe/blob/main/standards/SPIFFE-ID.md#22-path | ||
| func ValidatePathSegment(segment string) error { |
There was a problem hiding this comment.
maybe it worth to start using this ValidatePathSegment inside ValidatePath, that is doing the same thing
There was a problem hiding this comment.
Yes, they are very similar. Can we push that refactoring to another time?
There was a problem hiding this comment.
sure, we can just add an issue to not forgot about that
MarcosDY
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JoinPathSegments does not fail for dot segments but should.
This PR also exports ValidatePathSegment for convenience.