Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Validate RPC to Config service SDK. #55

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Add Validate RPC to Config service SDK. #55

merged 5 commits into from
Jul 1, 2024

Commits on Jun 28, 2024

  1. Add Validate RPC to Config service SDK. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    33da288 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Updates to provide more "Validate" feedback. 

    Instead of passing one message, the API will pass back
one or more notes.  Each note is independent and will
provide feedback to the end user.

Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    dbd02f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Update proto/spire/service/common/config/v1/config.proto 

    Co-authored-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck @azdagron
    edwbuck and azdagron committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    72454c7 View commit details
    Browse the repository at this point in the history

  2. Update proto/spire/service/common/config/v1/config.proto 

    Co-authored-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck @azdagron
    edwbuck and azdagron committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2fdf140 View commit details
    Browse the repository at this point in the history

  3. Regen code after applying the comment changes. 

    Signed-off-by: Edwin Buck <edwbuck@gmail.com>
    @edwbuck
    edwbuck committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    39efac2 View commit details
    Browse the repository at this point in the history