-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track mentions of teams to which the user belongs #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the app tracked only user mentions by their name. However, GitHub also supports team mentions, which notify all team members.
This changeset adds support for tracking mentions of teams to which the user belongs.
Accessing an organization's team list, essential for verifying a user's team memberships, requires installing the GitHub app on the organization's account. Furthermore, mentions of teams belonging to organizations that have not installed the GitHub app are not displayed, even if the user is a member of those teams.
A team can be either visible or secret. Regardless of its visibility, the application accesses its mentions as long as it has permission to read the resource.
Note that mentions for teams in GitHub are cascading—mentioning a parent team automatically includes all members of its child teams. Pingh, however, does not support this functionality. A team's mention is only visible if the team itself is explicitly mentioned using its tag.
Several changes were made to the mention selection process:
Additionally, the design of the Mentions page was updated:
The content of the notifications was also updated: