Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track mentions of teams to which the user belongs #77

Merged
merged 29 commits into from
Dec 20, 2024

Conversation

MykytaPimonovTD
Copy link
Contributor

@MykytaPimonovTD MykytaPimonovTD commented Dec 19, 2024

Previously, the app tracked only user mentions by their name. However, GitHub also supports team mentions, which notify all team members.

This changeset adds support for tracking mentions of teams to which the user belongs.

Accessing an organization's team list, essential for verifying a user's team memberships, requires installing the GitHub app on the organization's account. Furthermore, mentions of teams belonging to organizations that have not installed the GitHub app are not displayed, even if the user is a member of those teams.

A team can be either visible or secret. Regardless of its visibility, the application accesses its mentions as long as it has permission to read the resource.

Note that mentions for teams in GitHub are cascading—mentioning a parent team automatically includes all members of its child teams. Pingh, however, does not support this functionality. A team's mention is only visible if the team itself is explicitly mentioned using its tag.

Several changes were made to the mention selection process:

  • Mentions made by the user themselves are ignored.
  • Duplicate mentions within the same item are removed. For instance, if two teams are mentioned in the same comment and the user is a member of both, the mention will be shown only once.

Additionally, the design of the Mentions page was updated:

Screenshot 2024-12-19 at 17 35 39

The content of the notifications was also updated:

Screenshot 2024-12-19 at 17 36 10

@MykytaPimonovTD MykytaPimonovTD self-assigned this Dec 19, 2024
@MykytaPimonovTD MykytaPimonovTD marked this pull request as ready for review December 20, 2024 09:22
@MykytaPimonovTD MykytaPimonovTD merged commit 9180bac into master Dec 20, 2024
1 check passed
@MykytaPimonovTD MykytaPimonovTD deleted the team-mentions branch December 20, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants