Migrate to Spine 1.7.0 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
alexander-yevsyukov
approved these changes
Dec 17, 2020
| *.jar | ||
| *.war | ||
| *.ear | ||
| # |
There was a problem hiding this comment.
I don't think we need to have (c) statement in .gitignore
There was a problem hiding this comment.
Yep, I'll remove this one from here and I created the issue SpineEventEngine/config#163 to refine where we'd like to have (c) and where not.
README.md
Outdated
|
|
||
| * Multiple related Aggregate. | ||
|
|
There was a problem hiding this comment.
Why this change?
There was a problem hiding this comment.
Just looks a bit spacier for my liking. But, I guess in this case it's better to have them condensed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the example app to the latest released Spine v1.7.0 and resolves the breaking changes related to the migration.
As part of the PR, I have also updated the IDEA configs effectively copying them from the latest
configmodule version (the commit SpineEventEngine/config@c74b74f).I have also addressed new errorprone warnings while I had to update dependencies in order to match ones from the new Spine libraries.