move deploy and login to spin cloud
#1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
approved these changes
Feb 14, 2023
rajatjindal
reviewed
Feb 14, 2023
radu-matei
reviewed
Feb 14, 2023
bacongobbler
force-pushed
the
spin-cloud
branch
2 times, most recently
from
6f99e70 to
fd67c3d
Compare
itowlson
approved these changes
Feb 14, 2023
bacongobbler
force-pushed
the
spin-cloud
branch
3 times, most recently
from
109948d to
394049b
Compare
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
bacongobbler
force-pushed
the
spin-cloud
branch
from
394049b to
8ac7598
Compare
michelleN
reviewed
Feb 15, 2023
There was a problem hiding this comment.
The command help for spin deploy and spin cloud deploy look different. I think we should make these the same?
$ spin deploy --help
spin-deploy
Deploy a Spin application
USAGE:
spin deploy [OPTIONS]
$ spin cloud deploy --help
spin-cloud-deploy
Package and upload an application to the Fermyon Platform
USAGE:
spin cloud deploy [OPTIONS]
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
|
Nice catch. This seems to be due to the fact that Fixed in 7b08785. |
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
|
Did the same in 4e62660 for |
michelleN
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1117