Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Re-enable integration tests #11

Closed
Mossaka opened this issue Feb 5, 2024 · 7 comments
Closed

CI: Re-enable integration tests #11

Mossaka opened this issue Feb 5, 2024 · 7 comments

Comments

@Mossaka
Copy link
Member

Mossaka commented Feb 5, 2024

#9 re-enables make build in the CI, but make test is still failing. Needs more investigation.

@radu-matei
Copy link
Member

Is the test running in the container image?
https://github.com/spinkube/containerd-shim-spin/blob/main/Makefile#L6

@Mossaka
Copy link
Member Author

Mossaka commented Feb 16, 2024

@Mossaka
Copy link
Member Author

Mossaka commented Feb 16, 2024

@kate-goldenring
Copy link
Collaborator

@Mossaka can we switch the tests over to using spin registry push rather than docker images? Happy to take a look at fixing the tests

@Mossaka
Copy link
Member Author

Mossaka commented Mar 6, 2024

Sounds good to me!

@endocrimes
Copy link

endocrimes commented Mar 7, 2024

@kate-goldenring we probably want to have tests that cover both cases (docker build and spin registry push) - so we don't accidentally break them

@jsturtevant
Copy link
Contributor

#35 solved this and we have #37 to track adding tests for spin registry push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants