fix(tests): get integration tests passing #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-goldenring
requested review from
Mossaka,
jsturtevant,
radu-matei and
devigned
as code owners
kate-goldenring
force-pushed
the
fix-integration-tests
branch
from
659c4c8 to
094ec54
Compare
kate-goldenring
force-pushed
the
fix-integration-tests
branch
2 times, most recently
from
b5aa61d to
5bb2155
Compare
|
I am not 100% sure but since the integration tests are running via cross does kubectl need to be installed in that container? https://github.com/spinkube/containerd-shim-spin/blob/main/cross/Dockerfile |
I thought kubectl should be installed in the host and then has a configuration to connect to the cluster, no? |
kate-goldenring
force-pushed
the
fix-integration-tests
branch
2 times, most recently
from
d7a2b5c to
6d53e13
Compare
|
It seems like there is no Could not find `protoc` installation and this build crate cannot proceed without |
kate-goldenring
force-pushed
the
fix-integration-tests
branch
from
6d53e13 to
5503bec
Compare
|
@jsturtevant @Mossaka the main thing i changed here is to not use cross. I also made sure dependencies for the tests are installed. I think this is a reasonable adjustment and will likely speed up the action as well to not test with |
jsturtevant
reviewed
Mar 12, 2024
kate-goldenring
force-pushed
the
fix-integration-tests
branch
from
5503bec to
5d73327
Compare
kate-goldenring
force-pushed
the
fix-integration-tests
branch
from
5d73327 to
6b858be
Compare
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
fix-integration-tests
branch
from
6b858be to
24644b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.