Add installation documentation to the README #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-goldenring
requested review from
Mossaka,
jsturtevant,
radu-matei and
devigned
as code owners
Mossaka
approved these changes
May 18, 2024
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
kate-goldenring
force-pushed
the
installation-in-readme
branch
from
12c5d26 to
ed44442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since moving the Spin shim to its own repo, we now have no explicit instructions on how to install it. We may wish to add this documentation to the SpinKube documentation in addition or instead. I like the idea of having it in the shim repo because it will be easier to update with releases and having installation instructions seems like the bare minimum for repo READMEs. I am happy to also contribute it to SpinKube documentation, as well.