feat(node-installer): #153 conditionally restart k0s controller service when present #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajpantuso
requested review from
Mossaka,
kate-goldenring,
jsturtevant,
radu-matei and
devigned
as code owners
Mossaka
approved these changes
Jul 23, 2024
|
Could you please sign your commit @Ajpantuso |
vdice
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Just wanted to mention that I tested this via the k0s quickstart/simple install (where svc is k0scontroller) and it worked great! Thanks @Ajpantuso.
Ajpantuso
force-pushed
the
ajpantuso/support_k0scontrollers
branch
from
38cf192 to
cea1b5b
Compare
Done |
|
emm GitHub still doesn't show your commit as signed. |
Ajpantuso
force-pushed
the
ajpantuso/support_k0scontrollers
branch
from
cea1b5b to
e785540
Compare
…er service when present Signed-off-by: Andrew Pantuso <ajpantuso@gmail.com>
Ajpantuso
force-pushed
the
ajpantuso/support_k0scontrollers
branch
from
e785540 to
ae4eb1e
Compare
Fixed, gpg key had just expired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #153