Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKIP 003: Configuring Runtime Options in the Spin Containerd Shim #4

Merged
merged 5 commits into from
Jul 16, 2024
Merged

SKIP 003: Configuring Runtime Options in the Spin Containerd Shim #4

merged 5 commits into from
Jul 16, 2024

Commits on Jul 10, 2024

  1. SKIP 00X: Configuring Runtime Options in the Spin Containerd Shim 

    Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
    @kate-goldenring
    kate-goldenring committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    a1e7aa1 View commit details
    Browse the repository at this point in the history

  2. Add terms section, add clarifier in front of each use of runtime, and… 

    … note on Spin app env vars

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
    @kate-goldenring
    kate-goldenring committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    a1a930e View commit details
    Browse the repository at this point in the history

  3. Clarify use of application variables 

    Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
    @kate-goldenring
    kate-goldenring committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    904a2b6 View commit details
    Browse the repository at this point in the history

  4. Improve flow of document to focus on lifetime of configuration an spe… 

    …cify default injection of env vars

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>

Add SQS trigger required environment variables

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
    @kate-goldenring
    kate-goldenring committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5993fb1 View commit details
    Browse the repository at this point in the history

  5. Revert to using application variables for configuring Spin components 

    Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>

Remove SpinKube CRD modifications from the scope of the SKIP

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>

Add environment variables alternative and expound on wording

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>

Move SKIP to folder

Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
    @kate-goldenring
    kate-goldenring committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    21a8164 View commit details
    Browse the repository at this point in the history