fix(kubernetes): explicitly set v1 k8s account providerVersion #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plumpy
approved these changes
Feb 26, 2020
maggieneterval
force-pushed
the
specify-v1
branch
from
b4aa647
to
d9f1cd9
Compare
|
Was wondering why this didn't seem to be taking effect on any run except master, but then realized that |
|
@spinnakerbot cherry-pick 1.18 |
|
@spinnakerbot cherry-pick 1.17 |
|
@spinnakerbot cherry-pick 1.16 |
spinnakerbot
pushed a commit
that referenced
this pull request
Feb 26, 2020
|
Cherry pick successful: #16 |
spinnakerbot
pushed a commit
that referenced
this pull request
Feb 26, 2020
|
Cherry pick successful: #17 |
spinnakerbot
pushed a commit
that referenced
this pull request
Feb 26, 2020
|
Cherry pick successful: #18 |
maggieneterval
added a commit
that referenced
this pull request
Feb 26, 2020
maggieneterval
added a commit
that referenced
this pull request
Feb 26, 2020
maggieneterval
added a commit
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prepare for the upcoming removal of Spinnaker's Kubernetes V1 provider, we changed the default for accounts without a
providerVersionfromv1tov2. To fix the integration tests, we need to explicitly specifyv1as theproviderVersionfor the v1 tests.(Apologies for not anticipating that the
providerVersionwould be unspecified in these tests!)