K8s client staging #1831
Merged
K8s client staging #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w Caching agent using new java client library (splited the code)
…w Caching agent using new java client library (Statefulset Part 1)
…w Caching agent using new java client library (Statefulset Part 1)
…w Caching agent using new java client library (Statefulset Part 1) Removed Unwanted code
…w Caching agent using new java client library (Statefulset Part 2)
…w Caching agent using new java client library (Statefulset Part 2)
…w Caching agent using new java client library (Statefulset Part 2)
…er UI we need to have loadbalancer details also as its throw null pointer at com.netflix.spinnaker.clouddriver.controllers.ApplicationsController on line no: 101 (result.clusters[account] << new ApplicationClusterViewModel(name: cluster.name, loadBalancers: cluster.loadBalancers.name as TreeSet, serverGroups: cluster.serverGroups*.name as TreeSet, provider: cluster.type) at this call 'cluster.loadBalancers.name')
…/clouddriver into k8s-client-staging
…ded the right implementation) 2) Removed extra Space
…) in order to accommodate new controller , created new generic KubernatesController in KubernetesControllersCachingAgent
lwander
reviewed
Aug 24, 2017
| @@ -25,6 +25,7 @@ import io.kubernetes.client.ApiException | |||
| import io.kubernetes.client.Configuration | |||
| import io.kubernetes.client.apis.AppsV1beta1Api | |||
| import io.kubernetes.client.models.* | |||
| import io.kubernetes.client.apis.ExtensionsV1beta1Api | |||
| exceptionWrapper("daemonSets.list", "Get Daemon Sets", namespace) { | ||
| V1beta1DaemonSetList list = extApi.listNamespacedDaemonSet(namespace, null, null, null, null, API_CALL_TIMEOUT_SECONDS, null) | ||
| List<V1beta1DaemonSet> daemonSet = new ArrayList<V1beta1DaemonSet>() | ||
| list.items?.forEach({ item -> |
There was a problem hiding this comment.
I think you can just return list.items
| /** | ||
| * Need to check if this is required or not | ||
| */ | ||
| //this.replicas = daemonSet.spec?.replicas ?: 0 |
There was a problem hiding this comment.
I think it makes sense to keep for translating here, because this way you can see how many replicas are running in your cluster from the Spinnaker UI.
…ull Request 1831) 2) DaemonSetsSpec doesnot support Replicas : Checked the Documentation (V1beta1DaemonSetSpec.md)
…/clouddriver into k8s-client-staging
chlung
pushed a commit
to chlung/clouddriver
that referenced
this pull request
Aug 25, 2017
* feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (splited the code) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) Removed Unwanted code * feature(provider/kubernetes) : Indentation Issue Fixed * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : In order to see Statefulset in Spinnaker UI we need to have loadbalancer details also as its throw null pointer at com.netflix.spinnaker.clouddriver.controllers.ApplicationsController on line no: 101 (result.clusters[account] << new ApplicationClusterViewModel(name: cluster.name, loadBalancers: cluster.loadBalancers.name as TreeSet, serverGroups: cluster.serverGroups*.name as TreeSet, provider: cluster.type) at this call 'cluster.loadBalancers.name') * feature(provider/kubernetes) : Added Persistance Volume Claim for StatefulSet * feature(provider/kubernetes) : 1) Removed V1PersistentVolumeClaim (Added the right implementation) 2) Removed extra Space * feature(provider/kubernetes) : 1) Adding DaemonSets Support (Part 1)2) in order to accommodate new controller , created new generic KubernatesController in KubernetesControllersCachingAgent * feature(provider/kubernetes) : 1) Incorporated the Review comments (Pull Request 1831) 2) DaemonSetsSpec doesnot support Replicas : Checked the Documentation (V1beta1DaemonSetSpec.md) feat(provider/kubernetes): Create a new api adapter file and other changes. feat(provider/kubernetes): Fixed constructor change in unit test mock up object. refactor(provider/kubernetes): Clean up k8s client api dependency jars. feature(provider/kubernetes) Miscellaneous files for preapreing next commit statefulset deployment. feature(provider/kubernetes): remove extra line.
chlung
pushed a commit
to chlung/clouddriver
that referenced
this pull request
Aug 28, 2017
* feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (splited the code) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) Removed Unwanted code * feature(provider/kubernetes) : Indentation Issue Fixed * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : In order to see Statefulset in Spinnaker UI we need to have loadbalancer details also as its throw null pointer at com.netflix.spinnaker.clouddriver.controllers.ApplicationsController on line no: 101 (result.clusters[account] << new ApplicationClusterViewModel(name: cluster.name, loadBalancers: cluster.loadBalancers.name as TreeSet, serverGroups: cluster.serverGroups*.name as TreeSet, provider: cluster.type) at this call 'cluster.loadBalancers.name') * feature(provider/kubernetes) : Added Persistance Volume Claim for StatefulSet * feature(provider/kubernetes) : 1) Removed V1PersistentVolumeClaim (Added the right implementation) 2) Removed extra Space * feature(provider/kubernetes) : 1) Adding DaemonSets Support (Part 1)2) in order to accommodate new controller , created new generic KubernatesController in KubernetesControllersCachingAgent * feature(provider/kubernetes) : 1) Incorporated the Review comments (Pull Request 1831) 2) DaemonSetsSpec doesnot support Replicas : Checked the Documentation (V1beta1DaemonSetSpec.md) feat(provider/kubernetes): Create a new api adapter file and other changes. feat(provider/kubernetes): Fixed constructor change in unit test mock up object. refactor(provider/kubernetes): Clean up k8s client api dependency jars. feature(provider/kubernetes) Miscellaneous files for preapreing next commit statefulset deployment. feature(provider/kubernetes): remove extra line. feature(provider/kubernetes): remove custom template meta labels field. feature(provider/kubernetes): remove custom template meta labels field.
chlung
pushed a commit
to chlung/clouddriver
that referenced
this pull request
Aug 28, 2017
* feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (splited the code) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) Removed Unwanted code * feature(provider/kubernetes) : Indentation Issue Fixed * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : In order to see Statefulset in Spinnaker UI we need to have loadbalancer details also as its throw null pointer at com.netflix.spinnaker.clouddriver.controllers.ApplicationsController on line no: 101 (result.clusters[account] << new ApplicationClusterViewModel(name: cluster.name, loadBalancers: cluster.loadBalancers.name as TreeSet, serverGroups: cluster.serverGroups*.name as TreeSet, provider: cluster.type) at this call 'cluster.loadBalancers.name') * feature(provider/kubernetes) : Added Persistance Volume Claim for StatefulSet * feature(provider/kubernetes) : 1) Removed V1PersistentVolumeClaim (Added the right implementation) 2) Removed extra Space * feature(provider/kubernetes) : 1) Adding DaemonSets Support (Part 1)2) in order to accommodate new controller , created new generic KubernatesController in KubernetesControllersCachingAgent * feature(provider/kubernetes) : 1) Incorporated the Review comments (Pull Request 1831) 2) DaemonSetsSpec doesnot support Replicas : Checked the Documentation (V1beta1DaemonSetSpec.md) feat(provider/kubernetes): Create a new api adapter file and other changes. feat(provider/kubernetes): Fixed constructor change in unit test mock up object. refactor(provider/kubernetes): Clean up k8s client api dependency jars. feature(provider/kubernetes) Miscellaneous files for preapreing next commit statefulset deployment. feature(provider/kubernetes): remove extra line. feature(provider/kubernetes): remove custom template meta labels field. feature(provider/kubernetes): remove custom template meta labels field.
chlung
added a commit
to chlung/clouddriver
that referenced
this pull request
Sep 14, 2017
# This is the 1st commit message: feat(provider/kubernetes): Add a new k8s client java api client. (spinnaker#1779) * feat(provider/kubernetes): Add a new k8s client java api client. * feat(provider/kubernetes): Create a new api adapter file and other changes. * feat(provider/kubernetes): Fixed constructor change in unit test mock up object. * feat(provider/kubernetes): Fixed null checking. * feat(provider/kubernetes): Fixed license header. K8s client staging (spinnaker#1831) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (splited the code) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 1) Removed Unwanted code * feature(provider/kubernetes) : Indentation Issue Fixed * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : Adding support for Stateful set for new Caching agent using new java client library (Statefulset Part 2) * feature(provider/kubernetes) : In order to see Statefulset in Spinnaker UI we need to have loadbalancer details also as its throw null pointer at com.netflix.spinnaker.clouddriver.controllers.ApplicationsController on line no: 101 (result.clusters[account] << new ApplicationClusterViewModel(name: cluster.name, loadBalancers: cluster.loadBalancers.name as TreeSet, serverGroups: cluster.serverGroups*.name as TreeSet, provider: cluster.type) at this call 'cluster.loadBalancers.name') * feature(provider/kubernetes) : Added Persistance Volume Claim for StatefulSet * feature(provider/kubernetes) : 1) Removed V1PersistentVolumeClaim (Added the right implementation) 2) Removed extra Space * feature(provider/kubernetes) : 1) Adding DaemonSets Support (Part 1)2) in order to accommodate new controller , created new generic KubernatesController in KubernetesControllersCachingAgent * feature(provider/kubernetes) : 1) Incorporated the Review comments (Pull Request 1831) 2) DaemonSetsSpec doesnot support Replicas : Checked the Documentation (V1beta1DaemonSetSpec.md) # This is the commit message spinnaker#2: feat(provider/k8s): Prepare these new fileds or files for the statefu… (spinnaker#1853) * feat(provider/k8s): Prepare these new fileds or files for the statefulset. * feat(provider/k8s): Fixed change field name issue. * feat(provider/k8s): Fixed code duplication. * feat(provider/k8s): Added back replicaSetAnnotations field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lwander Please review it.
Regards
Prashant
We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:
Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.