Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes) : inbound/outbound rules only detected in apiVersion=network.k8s.io/v1 #3684

Merged
merged 8 commits into from
May 17, 2019

Conversation

darshannagaraja
Copy link
Contributor

This change accepts the new API version that was reported in the issue with title "inbound/outbound rules only detected in apiVersion=network.k8s.io/v1"
spinnaker/spinnaker#3173

Darshan added 7 commits May 3, 2019 18:12
Fetch updates to 1.13.x
fix(provider/google): ServiceAccount should be a Set<ServiceAccount> …
Fix for inbound/outbound rules only detected in
apiVersion=network.k8s.io/v1
Title: inbound/outbound rules only detected in apiVersion=network.k8s.io/v1
@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@darshannagaraja darshannagaraja changed the title Fix for Spinnaker Issue # 3173 fix(kubernetes) : inbound/outbound rules only detected in apiVersion=network.k8s.io/v1 May 17, 2019
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants