Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(titus): delete job with just id #3762

Merged
merged 1 commit into from
Jun 7, 2019
Merged

feat(titus): delete job with just id #3762

merged 1 commit into from
Jun 7, 2019

Conversation

emjburns
Copy link
Contributor

@emjburns emjburns commented Jun 6, 2019

we should be able to cancel a titus job with just the id

@emjburns emjburns requested a review from asher June 6, 2019 23:37
@spinnakerbot
Copy link
Contributor

We prefer that non-test backend code be written in Java or Kotlin, rather than Groovy. The following files have been added and written in Groovy:

  • clouddriver-titus/src/main/groovy/com/netflix/spinnaker/clouddriver/titus/deploy/converters/DestroyTitusJobAtomicOperationConverter.groovy

  • clouddriver-titus/src/main/groovy/com/netflix/spinnaker/clouddriver/titus/deploy/description/DestroyTitusJobDescription.groovy

  • clouddriver-titus/src/main/groovy/com/netflix/spinnaker/clouddriver/titus/deploy/ops/DestroyTitusJobAtomicOperation.groovy

  • clouddriver-titus/src/main/groovy/com/netflix/spinnaker/clouddriver/titus/deploy/validators/DestroyTitusJobDescriptionValidator.groovy

See our server-side commit conventions here.

@emjburns emjburns requested a review from robzienert June 6, 2019 23:57
@emjburns emjburns mentioned this pull request Jun 6, 2019
Merged
@emjburns emjburns merged commit 9f63766 into spinnaker:master Jun 7, 2019
justinrlee pushed a commit to justinrlee/clouddriver that referenced this pull request Jun 12, 2019
@emjburns @justinrlee
feat(titus): delete job with just id (spinnaker#3762)
bb5db6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asher asher asher approved these changes

@robzienert robzienert Awaiting requested review from robzienert

Assignees
No one assigned
Labels
target-release/1.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emjburns @spinnakerbot @asher