Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cloudfoundry): build client before creating filtered spaces #5313

Merged
merged 9 commits into from
Mar 24, 2021
Merged

refactor(cloudfoundry): build client before creating filtered spaces #5313

merged 9 commits into from
Mar 24, 2021

Conversation

zachsmith1
Copy link
Contributor

Moving the createFilteredSpaces method call to the bottom of the constructor. This makes sure that other things like the client are already instantiated before creating the filtered list of spaces.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@german-muzquiz german-muzquiz added the ready to merge Approved and ready for a merge label Mar 23, 2021
@mergify mergify bot added the auto merged Merged automatically by a bot label Mar 23, 2021
@mergify mergify bot merged commit 9769935 into spinnaker:master Mar 24, 2021
@zachsmith1 zachsmith1 deleted the fix/createcfclientbeforefilteredspaces branch March 24, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.26
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants