fix(google): Add partner metadata on instanceTemplate properties #6334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...google/src/main/java/com/netflix/spinnaker/clouddriver/google/compute/InstanceTemplates.java
Outdated
Show resolved
Hide resolved
jasonmcintosh
approved these changes
Jan 21, 2025
|
@mergify backport release-1.36.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
* fix(google): include partnerMetadata in InstanceTemplates * fix(google): remove default view and add tests * fix(google): format comment * fix(google): remove unused imports * fix(google): make FULL the default view in instanceTemplate client --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit fcc5394)
This was referenced Jan 21, 2025
mergify bot
added a commit
that referenced
this pull request
Jan 21, 2025
…) (#6335) * fix(google): include partnerMetadata in InstanceTemplates * fix(google): remove default view and add tests * fix(google): format comment * fix(google): remove unused imports * fix(google): make FULL the default view in instanceTemplate client --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit fcc5394) Co-authored-by: Edgar Garcia <63310723+edgarulg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloning a server group using the UI. The resourceManagerTags and partnerMetadata are not populated even if the deployment is configured with resourceManagerTags and partnerMetadata.
In clouddriver we include the resourceManagerTags under the instanceTemplate properties but by default the partnerMetadata is not included. See https://cloud.google.com/sdk/gcloud/reference/beta/compute/instance-templates/list
The fix only set the view option to "FULL". This ensure the partnerMetadata is included in the instanceTemplate properties.
Deck PR: spinnaker/deck#10161