fix(artifacts): Fix SpEL text input used in React components (#6712)

spinnaker · Mar 18, 2019 · 2ac15b2 · 2ac15b2
1 parent b4ca2b8
commit 2ac15b2
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/app/scripts/modules/core/src/widgets/spelText/SpelText.tsx b/app/scripts/modules/core/src/widgets/spelText/SpelText.tsx
@@ -44,20 +44,20 @@ export class SpelText extends React.Component<ISpelTextProps, ISpelTextState> {
     this.renderSuggestions();
   }
 
-  public componentDidUpdate() {
-    this.renderSuggestions();
+  public componentDidUpdate(_: Readonly<ISpelTextProps>, prevState: Readonly<ISpelTextState>): void {
+    if (prevState.textcompleteConfig !== this.state.textcompleteConfig) {
+      this.renderSuggestions();
+    }
   }
 
   private renderSuggestions() {
     const input = $(this.spelInputRef.current);
-    if (!input.attr('contenteditable')) {
-      input.attr('contenteditable', 'true');
-      input.textcomplete(this.state.textcompleteConfig, {
-        maxCount: 1000,
-        zIndex: 9000,
-        dropdownClassName: 'dropdown-menu textcomplete-dropdown spel-dropdown',
-      });
-    }
+    input.attr('contenteditable', 'true');
+    input.textcomplete(this.state.textcompleteConfig, {
+      maxCount: 1000,
+      zIndex: 9000,
+      dropdownClassName: 'dropdown-menu textcomplete-dropdown spel-dropdown',
+    });
   }
 
   public render() {