feat(amazon/serverGroup): warn that scaling policies will not work wh…

…en capacity is pinned (#4668)
spinnaker · Jan 16, 2018 · 3155b2f · 3155b2f
1 parent 1aee32d
commit 3155b2f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/app/scripts/modules/amazon/src/serverGroup/details/resize/resizeCapacity.component.html b/app/scripts/modules/amazon/src/serverGroup/details/resize/resizeCapacity.component.html
@@ -48,7 +48,6 @@
                                  min="{{$ctrl.command.min}}"
                                  max="{{$ctrl.command.max}}"/></div>
   </div>
-
 </div>
 <div ng-if="!$ctrl.command.advancedMode">
   <div class="form-group">
@@ -86,3 +85,19 @@
     </div>
   </div>
 </div>
+<div class="row" ng-if="$ctrl.command.min == $ctrl.command.max && $ctrl.serverGroup.scalingPolicies.length > 0">
+  <div class="col-md-7 col-md-offset-3">
+    <div class="well-compact alert alert-warning">
+      <b>Warning</b>: this server group has
+      <span ng-if="$ctrl.serverGroup.scalingPolicies.length == 1">a scaling policy.</span>
+      <span ng-if="$ctrl.serverGroup.scalingPolicies.length > 1">scaling policies.</span>
+      <span ng-if="!$ctrl.command.advancedMode">
+        Scaling policies will not take effect in Simple Mode.
+        Switch to <a href ng-click="$ctrl.command.advancedMode = true">Advanced Mode</a>.
+      </span>
+      <span ng-if="$ctrl.command.advancedMode">
+        Scaling policies will not take effect when <b>Min</b> is the same as <b>Max</b>.
+      </span>
+    </div>
+  </div>
+</div>
diff --git a/app/scripts/modules/amazon/src/serverGroup/details/resize/resizeCapacity.component.ts b/app/scripts/modules/amazon/src/serverGroup/details/resize/resizeCapacity.component.ts
@@ -3,7 +3,8 @@ import { IComponentOptions, module } from 'angular';
 const resizeCapacityComponent: IComponentOptions = {
   bindings: {
     command: '=',
-    currentSize: '='
+    currentSize: '=',
+    serverGroup: '='
   },
   templateUrl: require('./resizeCapacity.component.html'),
   controller: () => {}

diff --git a/app/scripts/modules/amazon/src/serverGroup/details/resize/resizeServerGroup.html b/app/scripts/modules/amazon/src/serverGroup/details/resize/resizeServerGroup.html
@@ -7,7 +7,8 @@ <h3>Resize {{serverGroup.name}}</h3>
     </div>
     <div class="modal-body confirmation-modal">
       <div class="form-horizontal">
-        <aws-resize-capacity command="command" current-size="currentSize"></aws-resize-capacity>
+        <aws-resize-capacity command="command" current-size="currentSize" server-group="serverGroup"></aws-resize-capacity>
+
       </div>
       <div class="row">
         <div class="col-sm-10 col-sm-offset-1">