Skip to content

Commit

Permalink
fix(provider/appengine): dont throw error when git credentials are mi…
Browse files Browse the repository at this point in the history
…ssing (#4768)
  • Loading branch information
Scott Bloch-Wehba-Seaward authored and danielpeach committed Feb 2, 2018
1 parent a6ec984 commit 424742b
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ class AppengineServerGroupBasicSettingsCtrl implements IController {
public onAccountChange(): void {
const account = this.findAccountInBackingData();
if (account) {
this.$scope.command.gitCredentialType = account.supportedGitCredentialTypes[0];
this.$scope.command.gitCredentialType = this.getSupportedGitCredentialTypes()[0];
this.$scope.command.region = account.region;
} else {
this.$scope.command.gitCredentialType = 'NONE';
Expand All @@ -82,7 +82,7 @@ class AppengineServerGroupBasicSettingsCtrl implements IController {

public getSupportedGitCredentialTypes(): GitCredentialType[] {
const account = this.findAccountInBackingData();
if (account) {
if (account && account.supportedGitCredentialsTypes) {
return account.supportedGitCredentialTypes;
} else {
return ['NONE'];
Expand Down

0 comments on commit 424742b

Please sign in to comment.