chore(artifactory): Polish imports and labels (#6693)

spinnaker · Mar 15, 2019 · 50cffc9 · 50cffc9
1 parent 4ac54ce
commit 50cffc9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/...cripts/modules/core/src/pipeline/config/triggers/artifactory/ArtifactoryTriggerConfig.tsx b/...cripts/modules/core/src/pipeline/config/triggers/artifactory/ArtifactoryTriggerConfig.tsx
@@ -1,9 +1,9 @@
 import * as React from 'react';
 import Select, { Option } from 'react-select';
 
-import { ITriggerConfigProps } from '@spinnaker/core';
 import { IArtifactoryTrigger } from 'core/domain/ITrigger';
 import { ArtifactoryReaderService } from './artifactoryReader.service';
+import { ITriggerConfigProps } from '../ITriggerConfigProps';
 
 export interface IArtifactoryTriggerConfigProps extends ITriggerConfigProps {
   trigger: IArtifactoryTrigger;
@@ -32,17 +32,14 @@ export class ArtifactoryTriggerConfig extends React.Component<
     });
   }
 
-  private artifactorySearchNameChanged = (option: Option<string>) => {
-    const searchName = option.value;
-    Object.assign(this.props.trigger, { artifactorySearchName: searchName });
+  private onArtifactorySearchNameChanged = (option: Option<string>) => {
+    Object.assign(this.props.trigger, { artifactorySearchName: option.value });
     this.props.fieldUpdated();
-    this.setState({});
   };
 
   public render() {
-    const { trigger } = this.props;
     const { artifactorySearchNames } = this.state;
-    const { artifactorySearchName } = trigger;
+    const { artifactorySearchName } = this.props.trigger;
     return (
       <div className="sp-formItem">
         <div className="sp-formItem__left">
@@ -53,8 +50,8 @@ export class ArtifactoryTriggerConfig extends React.Component<
             <span className="field">
               <Select
                 value={artifactorySearchName}
-                placeholder="Select Artifactory name"
-                onChange={this.artifactorySearchNameChanged}
+                placeholder="Select Artifactory search name..."
+                onChange={this.onArtifactorySearchNameChanged}
                 options={artifactorySearchNames.map((name: string) => ({ label: name, value: name }))}
                 clearable={false}
               />

diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/artifactory/artifactoryTrigger.ts b/app/scripts/modules/core/src/pipeline/config/triggers/artifactory/artifactoryTrigger.ts
@@ -1,5 +1,5 @@
+import { Registry } from 'core/registry';
 import { ArtifactoryTriggerConfig } from './ArtifactoryTriggerConfig';
-import { Registry } from '@spinnaker/core';
 
 Registry.pipeline.registerTrigger({
   label: 'Artifactory',