fix(google): safe healthcheck lookups when cloning server group

spinnaker · Jan 17, 2019 · 9f90ebd · 9f90ebd
1 parent b920442
commit 9f90ebd
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/...cripts/modules/google/src/serverGroup/configure/wizard/cloneServerGroup.gce.controller.js b/...cripts/modules/google/src/serverGroup/configure/wizard/cloneServerGroup.gce.controller.js
@@ -373,7 +373,7 @@ module.exports = angular
         return $uibModalInstance.close($scope.command);
       }
 
-      const healthCheckUrl = $scope.command.autoHealingPolicy.healthCheck;
+      const healthCheckUrl = _.get($scope.command, 'autoHealingPolicy.healthCheck');
       if (healthCheckUrl) {
         const { healthCheckName, healthCheckKind } = parseHealthCheckUrl(healthCheckUrl);
         $scope.command.autoHealingPolicy.healthCheck = healthCheckName;
@@ -389,7 +389,10 @@ module.exports = angular
         $scope.command.tags = origTags;
         $scope.command.loadBalancers = origLoadBalancers;
         $scope.command.securityGroups = gceTagManager.inferSecurityGroupIdsFromTags($scope.command.tags);
-        $scope.command.autoHealingPolicy.healthCheck = healthCheckUrl;
+
+        if (healthCheckUrl) {
+          $scope.command.autoHealingPolicy.healthCheck = healthCheckUrl;
+        }
 
         return promise;
       });