fix(google): GCE create server group and load balancer fixes (#6806)

* fix(google): safe call of onTypeChanged in v2InstanceTypeSelector * fix(google): safe lookup and set of namedPorts in loadBalancingPolicySelector
spinnaker · Apr 2, 2019 · bdcbc97 · bdcbc97
1 parent 700b8f6
commit bdcbc97
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...scripts/modules/core/src/serverGroup/configure/common/v2InstanceTypeSelector.component.ts b/...scripts/modules/core/src/serverGroup/configure/common/v2InstanceTypeSelector.component.ts
@@ -77,7 +77,7 @@ class V2InstanceTypeSelectorController implements IComponentController {
         this.command.viewState.instanceTypeDetails = instanceTypeDetails;
       });
 
-    this.onTypeChanged(this.command.instanceType);
+    this.onTypeChanged && this.onTypeChanged(this.command.instanceType);
   };
 
   public getStorageDescription = (instanceType: IPreferredInstanceType) => {

diff --git a/...serverGroup/configure/wizard/loadBalancingPolicy/loadBalancingPolicySelector.component.ts b/...serverGroup/configure/wizard/loadBalancingPolicy/loadBalancingPolicySelector.component.ts
@@ -82,8 +82,8 @@ class GceLoadBalancingPolicySelectorController implements IController {
   }
 
   public addNamedPort() {
-    if (!this.command.loadBalancingPolicy.namedPorts) {
-      this.command.loadBalancingPolicy.namedPorts = [];
+    if (!get(this.command, 'loadBalancingPolicy.namedPorts')) {
+      set(this.command, 'loadBalancingPolicy.namedPorts', []);
     }
 
     this.command.loadBalancingPolicy.namedPorts.push({ name: '', port: 80 });