fix(eslint): Fix eslint warnings for no-useless-escape

app/scripts/modules/appengine/src/helpContents/appengineHelpContents.ts

@@ -60,7 +60,7 @@ const helpContents = [
   },
   {
     key: 'appengine.serverGroup.stopPreviousVersion',
-    value: `If selected, the previously running server group in this server group\'s <b>service</b>
+    value: `If selected, the previously running server group in this server group's <b>service</b>
               (Spinnaker load balancer) will be stopped. This option will be respected only if this server group will
               be receiving all traffic and the previous server group is using manual scaling.`,
   },

app/scripts/modules/cloudfoundry/src/serverGroup/configure/wizard/sections/configurationSettings/ConfigurationSettings.cf.tsx

@@ -230,7 +230,7 @@ export class CloudFoundryServerGroupConfigurationSettings
       }
       if (values.manifest.routes) {
         const routeErrors = values.manifest.routes.map((route: string) => {
-          const regex = /^([a-zA-Z0-9_-]+)\.([a-zA-Z0-9_.-]+)(:[0-9]+)?([\/a-zA-Z0-9_-]+)?$/gm;
+          const regex = /^([-\w]+)\.([-.\w]+)(:\d+)?([-/\w]+)?$/gm;
           if (route && regex.exec(route) === null) {
             return `A route did not match the expected format "host.some.domain[:9999][/some/path]"`;
           }

app/scripts/modules/core/src/forms/numberList/numberList.component.ts

@@ -116,7 +116,7 @@ class NumberListComponent implements IComponentOptions {
               ng-class="{active: !$ctrl.parameterized}"
               ng-click="$ctrl.toggleParameterization(true)"
               uib-tooltip="Toggle to enter expression">
-              $\{…\}
+              $\{…}
       </button>
     </div>
     <div ng-if="!$ctrl.parameterized" class="row-number" ng-repeat="entry in $ctrl.backingModel track by $index">

app/scripts/modules/core/src/pipeline/create/CreatePipelineModal.tsx

@@ -271,7 +271,7 @@ export class CreatePipelineModal extends React.Component<ICreatePipelineModalPro
   };
 
   public validateNameCharacters(): boolean {
-    return /^[^\\\^/^?^%^#]*$/.test(this.state.command.name); // Verify name does not include: \, ^, ?, %, #
+    return /^[^\\^/?%#]*$/.test(this.state.command.name); // Verify name does not include: \, ^, ?, %, #
   }
 
   public validateNameIsUnique(): boolean {

app/scripts/modules/core/src/projects/configure/ProjectAttributes.tsx

@@ -27,12 +27,12 @@ export class ProjectAttributes extends React.Component<IProjectAttributesProps,
     const errors: FormikErrors<IProject> = {};
 
     const isValidName = (name: string) => {
-      const namePattern = /^[^\\\^/^?^%^#]*$/;
+      const namePattern = /^[^\\^/?%#]*$/;
       return name.match(namePattern);
     };
 
     const isValidEmail = (email: string) => {
-      const emailPattern = /^(.+)\@(.+).([A-Za-z]{2,6})/;
+      const emailPattern = /^(.+)@(.+).([A-Za-z]{2,6})/;
       return email.match(emailPattern);
     };
 

app/scripts/modules/core/src/widgets/spelText/JsonListBuilder.ts

@@ -24,6 +24,7 @@ export class JsonListBuilder {
   }
 
   public static escapeForRegEx(item: string): string {
+    // eslint-disable-next-line no-useless-escape
     return item ? item.replace(/[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\|]/g, '\\$&') : null;
   }
 
@@ -43,7 +44,7 @@ export class JsonListBuilder {
       if (!(isObject(value) || Array.isArray(value))) {
         if (
           !ignoreList.some(ignoreItem => {
-            const testerString = `[\'${ignoreItem}`;
+            const testerString = `['${ignoreItem}`;
             return entry.substr(0, testerString.length) === testerString;
           })
         ) {

app/scripts/modules/google/src/serverGroup/configure/wizard/advancedSettings/diskConfigurer.component.ts

@@ -150,7 +150,7 @@ class GceDiskConfigurer implements IComponentOptions {
                     This disk will use the image selected at the top of this dialogue.
                   </p>
                   <p class="small" style="margin: 0;" ng-if="$ctrl.command.viewState.mode === 'createPipeline' || $ctrl.command.viewState.mode === 'editPipeline'">
-                    This disk will use the image inferred from this pipeline\'s execution context.
+                    This disk will use the image inferred from this pipeline's execution context.
                   </p>
                 </div>
                 <ui-select ng-if="$index > 0"

app/scripts/modules/titus/src/serverGroup/configure/wizard/pages/ServerGroupBasicSettings.tsx

@@ -19,10 +19,13 @@ import { DockerImageAndTagSelector, DockerImageUtils } from '@spinnaker/docker';
 import { ITitusServerGroupCommand } from '../../../configure/serverGroupConfiguration.service';
 
 const isNotExpressionLanguage = (field: string) => field && !field.includes('${');
-const isStackPattern = (stack: string) =>
-  isNotExpressionLanguage(stack) ? /^([a-zA-Z_0-9._${}]*(\${.+})*)*$/.test(stack) : true;
+
+// Allow dot, underscore, and spel
+const isStackPattern = (stack: string) => (isNotExpressionLanguage(stack) ? /^([\w.]+|\${[^}]+})*$/.test(stack) : true);
+
+// Allow dot, underscore, caret, tilde, dash and spel
 const isDetailPattern = (detail: string) =>
-  isNotExpressionLanguage(detail) ? /^([a-zA-Z_0-9._$-{}\\\^~]*(\${.+})*)*$/.test(detail) : true;
+  isNotExpressionLanguage(detail) ? /^([\w.^~-]+|\${[^}]+})*$/.test(detail) : true;
 
 export interface IServerGroupBasicSettingsProps {
   app: Application;