Skip to content

Commit

Permalink
feat(provider/aws): Add help text to the LB internal checkbox (#4209)
Browse files Browse the repository at this point in the history
  • Loading branch information
Justin Reynolds authored and anotherchrisberry committed Oct 3, 2017
1 parent 3c3eccc commit e7f9ff4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions app/scripts/modules/amazon/src/help/amazon.help.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const helpContents: {[key: string]: string} = {
'aws.loadBalancer.detail':
`<p>(Optional) <b>Detail</b> is a string of free-form alphanumeric characters; by convention, we recommend using "frontend".</p>
<p>However, if your stack name needs to be longer (load balancer names are limited to 32 characters), consider changing it to "elb", or omit it altogether.</p>`,
'aws.loadBalancer.internal': 'Controls the load balancer scheme, <strong>not</strong> the subnet. By default, load balancers are created with a DNS name that resolves to public IP addresses. Specify internal to create a load balancer with a DNS name that resolves to private IP addresses.',
'aws.loadBalancer.stack': '(Optional) <b>Stack</b> is one of the core naming components of a cluster, used to create vertical stacks of dependent services for integration testing.',
'aws.loadBalancer.targetGroups': 'Add a target group if you want to associate this with an Application Load Balancer (ALB)',
'aws.loadBalancer.loadBalancers': 'And a load balancer directly if you created a Classic Load Balancer (a classic load balancer does not have target groups)',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
on-change="ctrl.subnetUpdated()"></subnet-select-field>
<!--Adding support for public facing elb. Display only for vpc-->
<div class="form-group" ng-if="ctrl.loadBalancerCommand.vpcId && !ctrl.viewState.hideInternalFlag">
<div class="col-md-3 sm-label-right"><b>Internal</b></div>
<div class="col-md-3 sm-label-right"><b>Internal</b> <help-field key="aws.loadBalancer.internal"></help-field></div>
<div class="col-md-7 checkbox">
<label><input type="checkbox"
ng-change="ctrl.internalFlagChanged()"
Expand Down

0 comments on commit e7f9ff4

Please sign in to comment.