Update gate Jenkins endpoint #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| function listBuildsForJob(master, job) { | ||
| return Restangular.one('builds', master).one('jobs', job).all('builds').getList(); | ||
| return Restangular.one('v2').one('builds', master).one('builds').one('jobs', job).getList(); |
There was a problem hiding this comment.
this url seems to be incorrect, it adds an additional /jobs/
http://192.168.99.100:8084/v2/builds/spinnaker/builds/jobs/SPINNAKER-package-igor
instead of
http://192.168.99.100:8084/v2/builds/spinnaker/builds/SPINNAKER-package-igor
|
@AMeng To not encode the URI component you'll need to do this riltsken@7900ccf I can't add commits to this branch unfortunately since it's under your account. |
| } | ||
|
|
||
| function listBuildsForJob(master, job) { | ||
| return Restangular.one('builds', master).one('jobs', job).all('builds').getList(); | ||
| return Restangular.one('v2').one('builds', master).one('builds').one(job).getList(); |
There was a problem hiding this comment.
Need to make sure job is not encoded here either
|
LGTM - needs a rebase |
|
Rebased. Remember that this depends on spinnaker/gate#161. It will break the UI without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: spinnaker/spinnaker#605
Depends on: spinnaker/gate#161