feat(provider/kubernetes): v2 resize modal #4274
Conversation
lwander
commented
Oct 16, 2017
lwander
commented
| @@ -18,6 +19,7 @@ export interface IServerGroup { | |||
| asg?: IAsg; | |||
| buildInfo?: any; | |||
| category?: string; | |||
| capacity?: ICapacity; | |||
There was a problem hiding this comment.
Seemed OK to add since it's in clouddriver's server group model.
| title: `Resizing ${this.serverGroup.name}`, | ||
| application: application, | ||
| modalInstance: $uibModalInstance, | ||
| } as any); |
There was a problem hiding this comment.
Any reason for the any cast? I think you gave $uibModalInstance the wrong type (which might by why) - should be IModalServiceInstance instead of IModalInstanceService.
There was a problem hiding this comment.
Ahh that would explain it - I thought typescript was mishandling the optional properties.
| this.current = this.serverGroup.capacity; | ||
| this.command = { | ||
| capacity: copy(this.current), | ||
| } as IResizeCommand; |
There was a problem hiding this comment.
You can initialize reason as null rather than cast like this.
| class="form-control input-sm highlight-pristine" | ||
| ng-model="ctrl.current.desired" | ||
| readonly/> | ||
| <span class="input-group-addon">pod<span ng-if="ctrl.current.desired != 1">s</span></span> |
There was a problem hiding this comment.
Nothing is going to go wrong here, since the input type is number, but should be a !== here and below.
| </div> | ||
| <div class="modal-footer"> | ||
| <user-verification account="ctrl.serverGroup.account" verification="ctrl.verification"></user-verification> | ||
| <button type="submit" ng-click="ctrl.resize()" style="display:none"></button> <!-- Allows form submission via enter keypress--> |
There was a problem hiding this comment.
I know this is everywhere...but can't you put ng-submit="ctrl.resize()" as a form attribute? Maybe I'm wrong.
There was a problem hiding this comment.
Sure thing - why do you prefer ng-submit?
There was a problem hiding this comment.
The hidden button feels a little hacky. Or not. Who knows.
There was a problem hiding this comment.
Not sure why, but the ng-submit form attribute causes the modal to close (but still submit the task) when you hit enter. With the hacky button you at get to see the task monitor do its thing.
There was a problem hiding this comment.
Oh. That's probably why it's being used. Now I know.
|
I can't seem to get github to update this PR. the branch in my lwander/deck repo is up-to-date... closing & reopening. |
