fix(provider/gce): Render namedPorts in svg details, not listeningPort. #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoCarrier
added a commit
to lookout/deck
that referenced
this pull request
Nov 1, 2017
* feat(core/pipeline): Support grouping stages that have a 'group' property (spinnaker#4117) * chore(*): Bump core and amazon module versions (spinnaker#4119) * fix(core): Seatbelt optionalStage directive to make sure stage exists (spinnaker#4121) * style(core): Found and replaced with closest colors for variables in color.less (spinnaker#4120) * removed all colors.less variables in core * Fixed scripting error + color mismatch * removed all colors.less variables in core * Fixed scripting error + color mismatch * Custom variables work only from inside css and not less * Moved the CSS back to less * feat(pipeline): Add pipeline config section for artifacts. (spinnaker#4118) Adds a section to pipeline config for declaring expected artifacts from trigger sources, and adds support in pub/sub triggers to select artifacts the trigger can produce. * fix(pipeline): Artifacts feature flagged off by default. (spinnaker#4126) * Fixed colors for the containers of server groups (spinnaker#4128) * fix(pipelines): fix back link when execution cannot be found (spinnaker#4125) * fix(pipelines): enlarge conditional expression input (spinnaker#4130) * fix(pipelines): refresh relative start time on interval (spinnaker#4129) * refactor(cluster): allow cluster pod header to be customized (spinnaker#4127) * refactor(cluster): allow cluster pod header to be customized * refactor(entityNotifications): refactor export * fix(pipelines): show loading message while fetching version history (spinnaker#4131) * fix(halconfig): add missing comma in halconfig settings.js (spinnaker#4134) * fix(build): revert yarn.lock changes (spinnaker#4136) * chore(core): bump package to 0.0.67 (spinnaker#4138) * refactor(core/formsy): Refactor formsy, create react app-config saver (spinnaker#4132) * feat(core/application): Add 'autoActivate' toggle for DataSources (spinnaker#4139) - Also deprecate DataSourceConfig * fix(search): add supplemental searching capability (spinnaker#4133) * when keyword search is not performed, removes applications and clusters from being searched by the the search API to speed up searching because both can be determined separately. * application information can be retrieved via the applications API endpoint - which is cached.. * cluster information for search results can be determined entirely from server groups. * adds ability to hydrate search results posthumously to add requested, extra information. * chore(core): bump package to 0.0.68 (spinnaker#4141) * refactor(core/formsy): Refactor formsy, create react app-config saver (spinnaker#4132) * feat(core/application): Add 'autoActivate' toggle for DataSources (spinnaker#4139) * fix(search): add supplemental searching capability (spinnaker#4133) * fix(search): add default method value (spinnaker#4142) * add default method value for post search result searchers so that it can intelligently process search result map lookups that don't exist. this is currently an artifact of region searching such that too many search results are found and they're culled in clouddriver so that only instance results come back. we need to change the way the results are returned for the new search to perhaps limit the search results to, say, _n per category_ rather than _n total_. need to have a think about this. * fix(docker) add ProxyPreserveHost On (spinnaker#4122) Signed-off-by: Haiwei Liu <carllhw@gmail.com> * feat(core/presentation): Add client side SpEL evaluator and Input Validator (spinnaker#4140) * fix(search): deduplicate cluster results by name (spinnaker#4145) * chore(deps): Update lodash-decorators to 4.4.1 to prep for switch from @autoBindMethods to @Bindall (spinnaker#4147) * chore(core): bump package to 0.0.69 (spinnaker#4148) * chore(search): update project icon (spinnaker#4151) * update the project search result icon and remove unnecessary fixed with font awesome class. * Fix subnet selection box (spinnaker#4124) * feat(provider/amazon): Show NLBs in the Load Balancer screen and allow NLB target groups to be selected when deploying (spinnaker#4149) * chore(*): Update react to 15.6.2 (spinnaker#4159) * feat(provider/dcos): Enabling strategies for DC/OS. (spinnaker#4158) * fix(react): Do not suppress unhandled rejections in promises. (spinnaker#4155) When react components chain off promises (angular $q promises) for callbacks (`setState()`, etc), any thrown errors would be swallowed by $qProvider.errorOnUnhandledRejections(true) This change will cause more noise in the console, but I think this is a necessary change. When other kinds of rejections occur and spam the console, we should address these cases individually. * fix revision history colors, tweak loading screen (spinnaker#4153) * style(splashscreen): tweak loading message/icon * fix(pipelines): fix revision history row colors * feat(provider/gce): Support named ports for global LBs. (spinnaker#4154) * chore(imports): remove unused import (spinnaker#4160) * Update Tooltip: Pipeline Config -> Property File (spinnaker#4156) Add docs from the 'pipeline expressions' guide about where the contents of the 'Property File' are usable, as well as a link back to the doc: https://www.spinnaker.io/guides/user/pipeline-expressions/ * refactor(*): Remove angular-loader in favor of using `.name` explicitly (spinnaker#4157) * refactor(*): Remove angular-loader in favor of using `.name` explicitly * fix tests * refactor(*): Replace class-autobind-decorator with lodash-decorators BindAll (spinnaker#4150) * chore(search): tweak CSS styles per feedback (spinnaker#4152) * fix(travis) prefer complete buildInfoUrl over composing it. (spinnaker#4143) * chore(core): bump package to 0.0.70 (spinnaker#4163) * chore(amazon): bump package to 0.0.34 (spinnaker#4164) * feat(kubernetes): surfacing timeout override for run job (spinnaker#4162) * feat(provider/gce): Support for connection draining in LBs. (spinnaker#4167) * (docs) Update Tooltip: Bake Configuration -> Base AMI (spinnaker#4161) * updated the not very helpful message in tooltip * updated the tooltip * style(development only): Added linting for colors (spinnaker#4165) * integrated postcss colorfix * Added a static color map * Added a static color map * remove the accidentally added color for testing * Remove postcss less * fix(core): Fix undefined for getting length of commits (spinnaker#4172) * fix: Fix the build. Remove bad @types/angular from yarn.lock (spinnaker#4174) * chore(*): Re-enable source maps (spinnaker#4169) * feat(core): Make HoverablePopover flip sides if there is not room to render on the provided side (spinnaker#4173) * Bump amazon (spinnaker#4170) * chore(*): Re-enable source maps * chore(amazon): bump package to 0.0.35 * chore(docker): bump package to 0.0.5 (spinnaker#4171) * feat(sourceMaps): Embed sources in sourcemaps for lib builds (spinnaker#4175) * fix(projects): restore project header width to 100% (spinnaker#4176) * fix(versionCheck): swallow exception if version.json fetch fails (spinnaker#4177) * chore(core): bump package to 0.0.71 (spinnaker#4178) * fix: Make sure jarDiffs has a default to prevent calling Object.keys on null (spinnaker#4179) * feat(core): versioned cloud provider service (spinnaker#4168) * chore(docker): Load settings-local.js inside docker container (spinnaker#4180) * feat(core): adds settings-local.js for Halyard users (spinnaker#4181) * clone stage now uses moniker (spinnaker#4166) * feat(core/pipeline): Scroll grouped stages popover (spinnaker#4182) * fix(pipeline_template): Cast numeric variable types during plan (spinnaker#4187) * fix(stage): fix default timeout for deploy stage (spinnaker#4186) * style(core/amazon/oracle): Updated spinners to use new designs (spinnaker#4190) * first pass at moving to new spinners * Fixed sizes for spinners * removed header tags for spinners * fix(pipelines): correctly rerender when editing JSON (spinnaker#4192) * updating server group writer to use moniker (spinnaker#4185) * refactor(clusterMatch): tweak cluster match component args, export more in lib (spinnaker#4191) * fix(search): fix advanced search page title (spinnaker#4193) * just set the title and don't try to get fancy with trying to figure out a title based on the search filters. * feat(provider/kubernetes): Register v2 provider (spinnaker#4183) * chore(core): bump package to 0.0.72 (spinnaker#4194) * chore(amazon): bump package to 0.0.36 (spinnaker#4195) * adds filter to only retrieve target cluster (spinnaker#4196) * fix(pipelines): properly sync plan/pipeline/renderablePipeline (spinnaker#4198) * chore(core): bump package to 0.0.74 (spinnaker#4199) * fix(core/pipeline): Fix configure view state callback for MPT (spinnaker#4203) * feat(pipeline): Change Artifact UI to use ExpectedArtifact model. (spinnaker#4202) * fix(artifacts): Get rid of 'unused' linter errors. (spinnaker#4205) * fix(provider/amazon) Enable & fix existing "Create LB" stage (spinnaker#4184) * Enable & fix existing "Create LB" stage INFRA_ENABLED=true env variable will properly enable the feature now. * fix: take out leftover console.log debug message * fix(providers/amazon): Fix editing existing LB Disable the unique name checking for pipeline configs, because if the LB already exists, the config will be overwritten during execution. * fix(providers/amazon): Respond to comments. Cleaned up some bits that were unnecessarily complicated, and still works. * feat(core): Versioned cloud provider deploy select (spinnaker#4201) * style(all): Removed all less color variables and using CSS4 consolidated colors (spinnaker#4204) * Cleaned all colors using colors.less and remove the file * Fixing alerts in pills and tags * more color fixes * feat(provider/aws): Add help text to the LB internal checkbox (spinnaker#4209) * fix(core): correct access modifier from local variable in versionSelector (spinnaker#4210) * refactor(provider/kubernetes): Move v1 code into v1 module (spinnaker#4211) * chore(search): update badge count label (spinnaker#4207) * updates the badge count label to add a `+` sign if the number of search results returned for a search category exceeds the page size sent with the search request. * feat(core): Version account lookup (spinnaker#4212) * fix(rollbacks): support for tolerating some instance failures (spinnaker#4144) * fix(provider/gce) Update max disk number for local-ssd to 8 from 4 (spinnaker#4214) New PR because I'm always going to fail at rebasing against deck correctly. From: https://cloud.google.com/compute/docs/disks/local-ssd#create_local_ssd "Each local SSD is 375 GB in size, but you can attach up to eight local SSD devices for 3 TB of total local SSD storage space per instance" 4 was the old limit Closes spinnaker/spinnaker#1945 * naming service for sequence only uses moniker now (spinnaker#4189) * refactor(moniker): application -> app (spinnaker#4213) * chore(modules): Use webpack-node-externals to exclude node_modules from @spinnaker/* bundles (spinnaker#4215) * fix(pipelines): show indicator when deleting pipeline config (spinnaker#4216) * style(core/amazon/google/kubernetes): Fixed adhoc hexcode colors to use spinnaker palette (spinnaker#4206) * Fixed color warnings from postcss-colorfix * Added github specific colors to styleguide * Fixed color warnings from postcss-colorfix * Added github specific colors to styleguide * chore(chore): bump package to 0.0.75 (spinnaker#4218) * chore(amazon): bump package to 0.0.37 (spinnaker#4219) * chore(tests): enable all tests (spinnaker#4217) * fix(amazon): properly assign credentials when editing load balancers (spinnaker#4221) * chore(amazon): bump package to 0.0.38 (spinnaker#4222) * feat(redblack): Expose `delayBeforeDisableSec` (spinnaker#4223) This allows a user to specify the amount of time that Spinnaker should wait after launching new instances and disabling old server groups or instances. * refactor(core/delivery): Convert execution filters to React (spinnaker#4197) * fix(executions): fix header alignment (spinnaker#4225) * chore(core): bump package to 0.0.77 (spinnaker#4226) * feat(script,jenkins): show contents of properties file (spinnaker#4227) * feat(moniker): adds monikers to stages that includes cluster-selects (spinnaker#4220) * chore(halconfig): lint halconfig/settings.js (spinnaker#4146) * feat(provider/kubernetes): Create manifest (spinnaker#4228) * fix(provider/kubernetes): Adds correct cloudprovider field (spinnaker#4229) Forgot I had this unstaged change before merging the manifest-deploy. Sorry :x * chore(core): bump package to 0.0.78 (spinnaker#4230) * chore(amazon): bump package to 0.0.39 (spinnaker#4231) * fix(core/modal): avoid throwing errors on modal $dismiss (spinnaker#4233) * feat(provider/kubernetes): V2 server group transformer (spinnaker#4232) * fix(core/http): retry http calls failing due to network issues (spinnaker#4234) * chore(core): bump package to 0.0.79 (spinnaker#4236) * fix(network): include backoff, max number of retries in network recovery (spinnaker#4238) * chore(core): bump package to 0.0.80 (spinnaker#4239) * feat(pipelines): use textarea for expression entry (spinnaker#4240) * feat(core): Version server group transformer delegate (spinnaker#4237) * chore(core): Remove some old files and convert a test to ts (spinnaker#4243) * feat(amazon): clarify naming/description on create load balancer/security group (spinnaker#4241) * fix(core): catch modal dismiss (spinnaker#4242) * chore(core): bump package to 0.0.81 (spinnaker#4244) * chore(amazon): bump package to 0.0.40 (spinnaker#4245) * fix(pipelines): guard against missing info on deploy stage (spinnaker#4246) * chore(halconfig): enable versioned providers (spinnaker#4247) * refactor(core): convert create pipeline to react (spinnaker#4248) * fix(core): catch dismiss of confirmation/cancel modals (spinnaker#4250) * chore(core): bump package to 0.0.83 (spinnaker#4251) * fix(provider/gce): Fix credential account handling in svg wizard. (spinnaker#4252) * feat(search): add server groups to clusters * populate the clusters with their server groups so that the availability data can be displayed. * refactor(core/search): Remove client-side fetch of servergroups in favor of culling missing entities on the server * fix(kubernetes): fix template loading (spinnaker#4256) * fix(amazon/securityGroup): Fix lint warning (spinnaker#4255) * refactore(core): Convert ExecutionStatus to react (spinnaker#4254) * fix(core/datasource): Possibly unhandled rejection: undefined (spinnaker#4257) * feat(provider/kubernetes): V2 server group details (spinnaker#4258) * chore(core): bump package to 0.0.84 (spinnaker#4259) * refactor(aws): make transformScalingPolicy method public (spinnaker#4261) * chore(amazon): bump package to 0.0.41 (spinnaker#4262) * refactor(core): Convert executions to react (spinnaker#4260) * fix(pipelines): add validator to webhook stage "method" field (spinnaker#4263) * fix(core): Fix rendering executions that have JSON in the parameters (spinnaker#4264) * feat(artifacts): Simplify expected artifacts (spinnaker#4266) * chore(core): Bump module to 0.0.85 (spinnaker#4265) * chore(core): Remove unused components (spinnaker#4269) * feat(artifact): Custom artifact helpers (spinnaker#4267) * fix(artifact): s/ul/ol (spinnaker#4271) * fix(appengine): allow non-default accounts in deploy dialogue (spinnaker#4270) * fix(appengine): remove unused import (spinnaker#4272) * feat(moniker) - adding monikers to the deploy stage (spinnaker#4268) * refactor(core): Convert executionDetailsSectionNav, executionStepDetails, statusGlyph to react (spinnaker#4273) * fix(core): catch exceptions on server group source when pipeline 404s (spinnaker#4275) * fix(core): Fix configure pipeline links when details is open (spinnaker#4276) * feat(moniker) - adding monikers to load balancers (spinnaker#4278) * chore(core): bump package to 0.0.86 (spinnaker#4277) * feat(provider/kubernetes): v2 resize modal (spinnaker#4279) * fix(provider/openstack): load balancer network and sg creation bugfixes (spinnaker#4281) fix(provider/openstack): Fixed network so it is filtered by account for load balancer creation. fix(provider/openstack): Fixed network so it refreshes when a new account is selected. fix(provider/openstack): Fixed network so it resets to default when a new account is selected and the selected network becomes invalid. fix(provider/openstack): Fixed security groups so it clears and refreshes when a new account is selected. fix(provider/openstack): Fixed security groups refresh button. fix(provider/openstack): Removed security group refresh tooltip that wasn't showing any data. * chore(package): update uirouter libs to latest (spinnaker#4283) * feat(entitytags): Show replaced server group details in popover (spinnaker#4284) As of spinnaker/orca#1705, `orca` is now adding previous server group details to the `spinnaker:metadata` tag. These details include: - previous server group name - image name - image id * chore(appengine): remove edit load balancer feature flag (spinnaker#4285) * fix(azure): retain `this` binding in azure cache initializer (spinnaker#4289) * feat(provider/gae): Specify artifact in GAE deploy from GCS. (spinnaker#4280) Also select between git and GCS during a GAE deploy, and select a storage account accordingly. * fix(core): render reason as HTML in tasks view (spinnaker#4290) * feat(provider/kubernetes): Enable setting of labels on k8s Service objects spinnaker/spinnaker#2035 (spinnaker#4287) * feat(provider/amazon): Rollback support for PREVIOUS_IMAGE strategy (spinnaker#4291) Rolling back to a previous image is available iff: - a `spinnaker:metadata` entity tag exists with `previousServerGroup` details - there are no other server groups in the cluster/region * refactor(core/delivery): Convert ExecutionDetails to react (spinnaker#4282) * chore(core): bump package to 0.0.87 (spinnaker#4292) * chore(core/amazon): make moniker changes library-friendly (spinnaker#4294) * chore(core): bump package to 0.0.88 (spinnaker#4295) * chore(amazon): bump package to 0.0.42 (spinnaker#4293) * refactor(core/delivery): Convert stageFailureMessage to react (spinnaker#4296) * fix(core/amazon): fix application name on server group command (spinnaker#4298) * fix(provider/gce): Render namedPorts in svg details, not listeningPort. (spinnaker#4299) * feat(amazon): Add load balancer dns name to target group details (spinnaker#4300) * fix(core/loadBalancer): Modify shouldComponentUpdate to allow for more specific updates (spinnaker#4302) * fix(amazon/loadBalancer): Modify shouldComponentUpdate to allow for more specific updates (spinnaker#4303) * refactor(*): Fix all the postcss-color warnings except the hard one (spinnaker#4304) * fix(core/loadBalancer): Actually check for all the changes to props (spinnaker#4305) * fix(core): Fix lint (spinnaker#4306) * refactor(core/delivery): Convert waitExecutionDetails to react (spinnaker#4297) * refactor(*): Consistent bracket spacing (spinnaker#4307) * fix(core/amazon): don't show copy capacity options for create server group (spinnaker#4301) * feat(provider/kubernetes): Enable annotations, labels and secrets for security groups (aka ingress resources) (spinnaker#2000) (spinnaker#4235) * fix(core): Navigate to the first stage if passed in stage does not exist (spinnaker#4309) * feat(rrb): Allow for specifying pipelines to run before disable (spinnaker#4308) * bugfix(aws): don't show copy capacity options for clone dialog either (spinnaker#4310) * feat(core): add detail filter to cluster/lb/sg views (spinnaker#4311) * chore(amazon): bump package to 0.0.44 (spinnaker#4312) * chore(core): bump package to 0.0.90 (spinnaker#4313) * fix(core/pipeline): Show errors in time window stage execution details (spinnaker#4315) * refactor(*): Remove duplicate execution details templates (spinnaker#4314) * chore(core): Bump core to 0.0.91 (spinnaker#4316) * chore(amazon): bump to 0.0.45 (spinnaker#4317) * fix(core): handle running execution fetch failure (spinnaker#4319) * fix(core): Fix wait stage task time updating (spinnaker#4320) * feat(core/modal): Silence all rejection warning in console when ui-bootstrap modals are closed/cancelled. * chore(core): bump package to 0.0.92 * fix(core): Fix lint (spinnaker#4321) * fix(core): Fix webpackJsonp not being defined for local dev (spinnaker#4322) * fix(core/executions): tweak padding on details tabs, status glyph (spinnaker#4323) * refactor(*): More execution details refactoring (spinnaker#4324) * fix(core): handle spel expressions in map editors (spinnaker#4325) * chore(core): bump package to 0.0.93 (spinnaker#4326) * feat(trigger/pubsub): Suggest subscriptions from echo configuration. (spinnaker#4328) * fix(amazon): do not set useSourceCapacity on clones (spinnaker#4329) * chore(amazon): bump package to 0.0.46 (spinnaker#4331) * fix(core): Stop grouping groups with only one stage (spinnaker#4332) * chore(core): remove happypack in favor of thread-loader/cache-loader (spinnaker#4330) I was trying to fix lint warnings (which happypack was somehow eating). HappyPack 4.0.0 has [fixed the problem](amireh/happypack#161 (comment)). However, it has also [removed support for caching](amireh/happypack#154 (comment)). There are now loaders which can effectively replace what we used happypack for (thread-loader and cache-loader). * chore(core): Remove console.log statement. (spinnaker#4333) * Cleanup phase 1 * fix(core): Fix groups from breaking executions view (spinnaker#4336) * added ECS help messages * Using our own footer for ECS now * some more cleanup * fix(core): replace word-break CSS with overflow-wrap (spinnaker#4334) * added help pop-ups in the ecs deploy modal * fix(core): Fix unhandled rejection on auth recheck (spinnaker#4335) * using our own ecs server group transformer * refactoring so i can take apart an AWS dependency * refactoring for the win * refactoring for the win * refactoring * progress on serverGroupCommandBuilder.service.js * progress on serverGroupCommandBuilder.service.js * fix(canary): Fix moniker for baseline/canary clusters * chore(core): bump package to 0.0.94 * chore(amazon): bump package to 0.0.47 * Cleaning up ServerGroupConfigurationService * removed security groups from serverGroupConfiguration.service.ts * removed keypairs from serverGroupConfiguration.service.ts * removed clutter * removed clutter: scalingpolicies * removed clutter: hard-coded aws constants * removing entions to aws * removing unused stuff * refactor(core/pipeline): Convert a few execution source details to react (spinnaker#4339) * refactor(core/pipeline): Rerefactor execution details to be less boilerplate-y * refactor(core/pipeline): Convert applySourceServerGroupCapactiyDetails to react * refactor(core/pipeline): Convert checkPreconditionsExecutionDetails to react * added a TODO * added ecs * Merged origin/master & fixed bugs * minor cleaning * ecsCloneServerGroupStage.js * clone server group controller * progress on clone server group controller * progress on clone server group controller * progress cleaning up serverGroupCommandBuilderService * progress on serverGroupCommandBuilder * cleaned instance details * made Amazon health checks Ecs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.