feat(pipeline_template): Better support for templated pipelines with dynamic sources - Take 2 #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jervi
force-pushed
the
support_previous_execution_context_for_pipeline_templates_take_2
branch
from
6e548af to
d951e61
Compare
anotherchrisberry
suggested changes
Nov 6, 2017
| <li role="presentation" ng-class="{selected: $ctrl.mode === 'pipeline'}"><a ng-click="$ctrl.mode = 'pipeline'">Configuration</a></li> | ||
| <li role="presentation" ng-class="{selected: $ctrl.mode === 'renderedPipeline'}"><a ng-click="$ctrl.mode = 'renderedPipeline'">Rendered pipeline</a></li> | ||
| </ul> | ||
| <div class="modal-body flex-fill" ng-if="$ctrl.mode == 'pipeline'"> |
jervi
force-pushed
the
support_previous_execution_context_for_pipeline_templates_take_2
branch
from
d951e61 to
e190ad7
Compare
anotherchrisberry
approved these changes
Nov 6, 2017
danielpeach
requested changes
Nov 6, 2017
| <span class="glyphicon glyphicon small glyphicon-alert"></span> This template has a dynamic source. The | ||
| configuration cannot be rendered before the pipeline has executed at least once. | ||
| </div> | ||
| <div class="band band-warning" ng-if="templateError && pipelineExecutions.length && !pipeline.isNew"> |
There was a problem hiding this comment.
This still swallows errors if you're not using dynamic sources. I have a config that doesn't render a pipeline properly - with these changes, when I load the pipeline config screen, there's no indication that anything's wrong.
The edit config modal should open if there's a problem rendering the template - this behavior isn't perfect, but it gives the user a chance to update their config (e.g., in the case they're missing a variable), and then view the rendering error if it still exists.
jervi
force-pushed
the
support_previous_execution_context_for_pipeline_templates_take_2
branch
from
e190ad7 to
98eb73c
Compare
…dynamic sources * Add "Rendered pipeline" tab to "Edit as JSON" modal for templated pipelines * Don't display error message when editing templated pipelines with dynamic source - real fix in Orca * Render execution graph when editing templated pipelines with dynamic source - real fix in Orca * Display warning in Deck if configuration can't be rendered because no executions have been run * Display information about which execution used for rendering * Let the user select which configuration that's used for rendering Depends on spinnaker/orca#1718 and spinnaker/gate#471
jervi
force-pushed
the
support_previous_execution_context_for_pipeline_templates_take_2
branch
from
98eb73c to
a62e114
Compare
danielpeach
approved these changes
Nov 8, 2017
…eline_templates_take_2
jervi
deleted the
support_previous_execution_context_for_pipeline_templates_take_2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second iteration of #4288, which had to be rolled back in #4362.
It was an oversight by me, I was not really aware that the pipeline executions sometimes had both a build number and a pipeline parent. This is fixed.
Original PR: