fix(provider/kubernetes): v2 move backing data out of stage #4539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't merge yet... something is going wrong in the stage config |
lwander
force-pushed
the
more-fix-mani
branch
from
91f8c50 to
b5a3ac4
Compare
|
all better |
lwander
force-pushed
the
more-fix-mani
branch
3 times, most recently
from
261e22a to
2213d0b
Compare
danielpeach
approved these changes
Nov 29, 2017
| @@ -35,7 +37,10 @@ class KubernetesEditManifestCtrl implements IController { | |||
| 'ngInject'; | |||
| this.kubernetesManifestCommandBuilder.buildNewManifestCommand(application, sourceManifest, sourceMoniker) | |||
| .then((builtCommand) => { | |||
| this.command = builtCommand; | |||
| const { command: command, metadata: metadata } = builtCommand; | |||
There was a problem hiding this comment.
This can be const { command, metadata } = builtCommand;.
You would only use that syntax if you want a variable with a different name than the key in builtCommand.
lwander
force-pushed
the
more-fix-mani
branch
from
2213d0b to
1f28cd9
Compare
lwander
force-pushed
the
more-fix-mani
branch
from
1f28cd9 to
b36ffa6
Compare
dkirillov
added a commit
to lookout/deck
that referenced
this pull request
Dec 6, 2017
* feat(provider/kubernetes): runJob logs (spinnaker#4501) add support for displaying logs for runJob * feat(core): Add a pagerDuty read service, tag, and select field (spinnaker#4507) * chore(core): Bump to 0.0.113 (spinnaker#4508) * feat(artifacts): show artifacts next to manifest (spinnaker#4510) * bug(core) - add missing div close that causes stage templates to not render. (spinnaker#4513) * chore(core/pagerDuty): Add field to the pager duty service interface * chore(core): Bump to 0.0.114 * fix(provider/amazon): Tags not copied when cloning ASG (spinnaker#4491) * perf(core/executions): consider pipeline filters when fetching executions (spinnaker#4509) * feat(core): console output jump to end (spinnaker#4511) constrain modal height and add shortcut to end of the output by jumping `pre` content to end. * chore(core): fix lint warnings (spinnaker#4516) * fix(core/executions): trigger filter collapse correctly (spinnaker#4515) * chore(core): bump package to 0.0.115 (spinnaker#4517) * chore(amazon): bump package to 0.0.52 (spinnaker#4518) * fix(amazon): provide better error message when bake stage fails (spinnaker#4519) * fix(core/pipeline): Pipeline graph overflow in firefox (spinnaker#4520) * fix(*/loadBalancer): Fix server group show/hide control (spinnaker#4521) * fix(*/loadBalancer): Fix a few undefined errors with load balancers (spinnaker#4524) * fix(core/pipeline): Fix undefined edge case in ScriptExecutionDetails (spinnaker#4526) * feat(kubernetes): export v2 provider (spinnaker#4523) * chore(kubernetes): bump npm package version (spinnaker#4527) * feat(webhooks): webhook trigger dialog (spinnaker#4522) * chore(core): Fix lint (spinnaker#4529) * fix(core/pipeline): De-duplicate state transitions for execution details (spinnaker#4531) * fix(amazon/loadBalancer): Edit load balancers in the context of the application they were created in/with (spinnaker#4532) * chore(core): bump to 0.0.116 (spinnaker#4533) * chore(amazon): bump to 0.0.53 (spinnaker#4534) * fix(core): reduce starting instance animations (spinnaker#4535) * refactor(core/pipeline): Convert singleExecutionDetails to react (spinnaker#4530) * refactor(core/loadBalancer): Remove unused loadBalancers component * refactor(core/pipeline): Convert singleExecutionDetails to react * chore(core): bump package to 0.0.117 (spinnaker#4536) * feat(provider/kubernetes): Add deploy manifest stage (spinnaker#4525) * fix(provider/kubernetes): fixup deploy manifest stage (spinnaker#4538) * fix(core): use inline element for instance groups (spinnaker#4540) * chore(core): bump package to 0.0.118 (spinnaker#4541) * fix(provider/kubernetes): v2 move backing data out of stage (spinnaker#4539) * feat(pubsub): support constraints (spinnaker#4542) * fix(core): prevent adding group stages, handle rendering gracefully (spinnaker#4543) * chore(core): bump package to 0.0.119 (spinnaker#4544) * feat(amazon): Support passing a capacity constraint during resize (spinnaker#4545) `clouddriver` can enforce that capacity of the server group being resized has not changed in the background. This addresses situations where autoscaling has occurred in the background and subsequently been "undone" by a concurrent resize operation. * config(provider/openstack) - change default protocol for load balancer health check to HTTP. (spinnaker#4546) * bug(provider/openstack) - filter networks for floating ip to the account selected. (spinnaker#4547) * feat(gce): UI for zone selection. (spinnaker#4548) * fix(artifacts): fix typo in artifact var (spinnaker#4549) * refactor(core/pipeline): Cleanup time boundary sorting/comparison (spinnaker#4551) * fix(provider/k8sv2): Move delete manifest form data into its own component (spinnaker#4550) * chore(amazon): bump package to 0.0.54 (spinnaker#4553) * feat(provider/kubernetes): deploy artifact from application (spinnaker#4552) * fix(core/task): Do not show tasks link if no application associated with task (spinnaker#4556) * refactor(core/entityTags): retrieve tags by application (spinnaker#4557) * fix(amazon): omit spinnaker metadata tags when cloning server groups (spinnaker#4554) * fix(core/pipelines): rerender view when first stage is removed (spinnaker#4558) * chore(chore): bump package to 0.0.120 (spinnaker#4559) * chore(amazon): bump package to 0.0.55 (spinnaker#4560) * Removed some console.logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way backingData & manifestText aren't stored in the pipeline definition.
FYI @andrewbackes this might break any pipelines you've already created with this stage