fix(core): fix next CRON trigger calculation offset #6242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CRON next run calculator works on UTC time. Since the Echo scheduler works in whatever timezone is configured, we were doing some really bad things to calculate the next run if there was an hourly restriction. The bad things worked most of the time, but that is arguably worse, since it would sometimes give the wrong calculation.
Turns out, the
next
method can take another parameter, which is the start date. So...we can just pass that in, offset back in time to UTC. This is a good thing, and gives us the correct calculation.It would be nice to get that value from the backend, but, for now, this is at least better.