fix(core): fix next CRON trigger calculation offset #6242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrsquared
approved these changes
Jan 2, 2019
anotherchrisberry
added a commit
that referenced
this pull request
Jan 7, 2019
#6315) * chore(core): Bump version to 0.0.305 80091f1 fix(core): disable manual executions while trigger data loads (#6301) 308a991 feat(core): use Ace Editor for pipeline/stage JSON editing (#6226) f455307 feat(core): allow setting params via query string on manual execution (#6302) c48bac2 feat(artifacts): Changed helm artifact API requests (#6202) 616e46e fix(core/account): Return empty array if no preferred zones are found in a region e052526 refactor(core/help): Switch HelpField to PureComponent 2c3e5df feat(artifacts): add ivy and maven expected artifact editors (#6241) 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) dac9b21 fix(core): fix next CRON trigger calculation offset (#6242) 6b7c1ec fix(core): avoid in sync race condition when saving pipelines (#6235) d29b359 feat(core): show pipeline stage durations by default (#6215) 70be323 feat(stage): manual judgement continue button moved to right (#6292) 641a283 styles(core): Making the main ui-view container positive relative (#6264) 425ca35 feat(core/deploy): Support `scaleDown` as part of a rolling red/black deployment (#6265) * chore(amazon): Bump version to 0.0.148 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) fb6e6c0 fix(aws): clarify all ports/protocols on IP range ingress (#6231) e571c95 fix(aws): provide help explanation when load balancer delete is disabled (#6236) 9a6d8fb feat(aws): make image sort options sticky; sort by TS by default (#6267) 73952e2 fix(amazon/loadBalancer): Restore the "security group removed" warning when switching regions * chore(titus): Bump version to 0.0.65 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CRON next run calculator works on UTC time. Since the Echo scheduler works in whatever timezone is configured, we were doing some really bad things to calculate the next run if there was an hourly restriction. The bad things worked most of the time, but that is arguably worse, since it would sometimes give the wrong calculation.
Turns out, the
nextmethod can take another parameter, which is the start date. So...we can just pass that in, offset back in time to UTC. This is a good thing, and gives us the correct calculation.It would be nice to get that value from the backend, but, for now, this is at least better.