fix(*): Remove all self closing tags in AngularJS templates #6446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self closing tags are invalid HTML except for a few specific tags, i.e.,
<br/>
,<input/>
, etc. In some cases markup following a self closed tag will be embedded inside the self closed tag. i.e.,is parsed as
AngularJS code relies on the browser html parser, and so we shouldn't use self-closed tags in AngularJS code.
Reference: angular/angular.js#1953 (comment)
This issue manifest as oddly placed icons when I changed typescript module type from
commonjs
toesnext
in #6445 (and I have no idea why that would alter the behavior)