Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): Remove all self closing tags in AngularJS templates #6446

Merged

Conversation

christopherthielen
Copy link
Contributor

Self closing tags are invalid HTML except for a few specific tags, i.e., <br/>, <input/>, etc. In some cases markup following a self closed tag will be embedded inside the self closed tag. i.e.,

<i class="fa fa-spin"/> 
<h1>hello</h1>

is parsed as

<h1>hello</h1>
</i>

AngularJS code relies on the browser html parser, and so we shouldn't use self-closed tags in AngularJS code.

Reference: angular/angular.js#1953 (comment)

This issue manifest as oddly placed icons when I changed typescript module type from commonjs to esnext in #6445 (and I have no idea why that would alter the behavior)
screen shot 2019-01-28 at 3 52 36 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants