Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider/azure): Add Application Name Validator for Azure #6473

Merged
merged 5 commits into from
Feb 12, 2019
Merged

fix(provider/azure): Add Application Name Validator for Azure #6473

merged 5 commits into from
Feb 12, 2019

Conversation

neil-yechenwei
Copy link

Currently spinnaker doesn't validate application name for azure.
So add an application name validator for azure.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • f6159dc: add application name validation for azure

  • 6e012ca: update regex

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@mybayern1974
Copy link
Contributor

@sbwsg , @lwander , @duftler , a kindly ping to review this PR. The purpose of this PR is, without this fix, the user is likely to create an invalid application name that will be used in the later Azure deploy stage, in which things will break w/o friendly error notifications. So the PR is to prevent that at the very beginning.

@duftler
Copy link

duftler commented Feb 12, 2019

I think SpinnakerBot is pointing out that the commit message needs its format updated, not that the PR description needs its format updated.

@duftler duftler requested review from a user and maggieneterval February 12, 2019 12:52
@maggieneterval
Copy link
Contributor

@neil-yechenwei this looks good to go, would you mind resolving the conflicts when you get a chance so we can merge? Thanks!

@duftler duftler merged commit 2bad922 into spinnaker:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants