fix(core): Max remaining ASG should honor value being removed #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archana-s
changed the title
|
Clever! |
anotherchrisberry
approved these changes
Feb 11, 2019
archana-s
pushed a commit
that referenced
this pull request
Feb 12, 2019
7e4b457 fix(amazon): Display capacity as text if using SPEL (#6535) 27d8a12 chore(eslint): Fix lint errors a8c1749 chore(package): Just Update Prettier™ 58d3e90 fix(core): enable new traffic guards by default (#6527) 578a7fd fix(core): only use <g> for popovers in within SVGs (#6530) 70b8e01 refactor(validation): First class support for required or optional (#6526) 0eb3e29 feat(core): rename feature flag for managed pipeline templates v2 ui (#6525) 3359789 fix(core): Max remaining ASG should honor value being removed and reflect correctly (#6522) bc2a423 feat(core): add feature flag for managed pipeline templates v2 (#6520) 9eccc0f refactor(artifacts): Generalize artifact delegate for reuse (#6495) a2ebca0 fix(amazon/core): Sorting order of regions in bake stage + lint fix (#6518) b1b04f0 fix(core): introduce state when the modal has been initialized (#6516) ed74abf chore(core): update banner spec
anotherchrisberry
pushed a commit
that referenced
this pull request
Feb 13, 2019
* chore(core): Bump version to 0.0.330 7e4b457 fix(amazon): Display capacity as text if using SPEL (#6535) 27d8a12 chore(eslint): Fix lint errors a8c1749 chore(package): Just Update Prettier™ 58d3e90 fix(core): enable new traffic guards by default (#6527) 578a7fd fix(core): only use <g> for popovers in within SVGs (#6530) 70b8e01 refactor(validation): First class support for required or optional (#6526) 0eb3e29 feat(core): rename feature flag for managed pipeline templates v2 ui (#6525) 3359789 fix(core): Max remaining ASG should honor value being removed and reflect correctly (#6522) bc2a423 feat(core): add feature flag for managed pipeline templates v2 (#6520) 9eccc0f refactor(artifacts): Generalize artifact delegate for reuse (#6495) a2ebca0 fix(amazon/core): Sorting order of regions in bake stage + lint fix (#6518) b1b04f0 fix(core): introduce state when the modal has been initialized (#6516) ed74abf chore(core): update banner spec * chore(amazon): Bump version to 0.0.170 7e4b457 fix(amazon): Display capacity as text if using SPEL (#6535) 27d8a12 chore(eslint): Fix lint errors a8c1749 chore(package): Just Update Prettier™ a2ebca0 fix(amazon/core): Sorting order of regions in bake stage + lint fix (#6518)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxRemainingAsgs use default placeholder value of 2 even if it is manually removed.
Scenario: A user configures a deploy stage with redblack and creates a cluster. This has a default maxRemainingAsg value of 2 by default. Now the user removes the maxRemainingAsgs from the pipeline JSON and saves the config. When the user gets to the cluster configuration in the UI, the maxRemainingAsg is set to 2 even though the value has been removed. This is incorrect because now the number of remaining ASGs is infinite and not 2 because it is not set.
In this solution, I read if the strategy has already been set to determine if its a first time cluster config or existing cluster config. Based on that, it chooses whether to show the default values or not. This solution is easier than passing down if the cluster is in "create" or "edit" mode.