fix(core/executions): Disable text selection when re-ordering pipelines #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anotherchrisberry
approved these changes
Feb 22, 2019
|
yeah it's great for making user-hostile interfaces without the fuss: |
christopherthielen
approved these changes
Feb 22, 2019
erikmunson
added a commit
to erikmunson/deck
that referenced
this pull request
Feb 25, 2019
3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (spinnaker#6604) 754c540 Merge branch 'master' into lb-is-loading 70fb404 fix(core/executions): Disable text selection when re-ordering pipelines (spinnaker#6603) a35b4cb Merge branch 'master' into lb-is-loading 1d320d6 Merge branch 'master' into lb-is-loading c026514 Merge branch 'master' into lb-is-loading cf528dc fix(core): loading spinner for LBs not dismissed
erikmunson
added a commit
that referenced
this pull request
Feb 25, 2019
#6615) * chore(core): Bump version to 0.0.339 3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (#6604) 754c540 Merge branch 'master' into lb-is-loading 70fb404 fix(core/executions): Disable text selection when re-ordering pipelines (#6603) a35b4cb Merge branch 'master' into lb-is-loading 1d320d6 Merge branch 'master' into lb-is-loading c026514 Merge branch 'master' into lb-is-loading cf528dc fix(core): loading spinner for LBs not dismissed * chore(amazon): Bump version to 0.0.177 510557f fix(amazon/serverGroup): Do not apply default AZs unless the user wants to usePreferredZones (#6609) * chore(titus): Bump version to 0.0.77 5e77299 fix(titus): Help users with iam profile setting (#6552)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When re-ordering pipelines in the filter sidebar, it can get kinda wonky if you accidentally make the browser think you're selecting text. If you manage to click + drag just right, sometimes it even thinks you're trying to drag a multi-line text selection for copy-pasting.
This switches off text selection when entering re-ordering mode for strategies and normal pipelines. Outside re-ordering mode you can still select the pipeline names to copy-paste, if that's something you're into.