refactor(titus): Moving constraints from lists to maps #7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmquach
requested review from
anotherchrisberry,
christopherthielen and
aravindmd
| originalCluster.hardConstraints.reduce((a, c) => set(a, c, 'true'), {})) || | ||
| {}, | ||
| soft: | ||
| (originalCluster.constarints && originalCluster.constarints.soft) || |
There was a problem hiding this comment.
I feel like I am constarintly expecting this line to be falsy
anotherchrisberry
suggested changes
May 31, 2019
|
Oh geez. Nice catch thanks! |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (spinnaker#7068) 008544f refactor(titus): Moving constraints from lists to maps (spinnaker#7069)
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving deck over to maps so we can get quickly get rid of the lists (because it's not possible to represent a map as a list).
API already supports the map based constraints:
constraintsmap (if present) will take precedence over the old lists, so we're safe to send only maps