-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core/presentation): Consolidate Checklist and ChecklistInput components #7077
Merged
christopherthielen
merged 2 commits into
spinnaker:master
from
christopherthielen:checklist-input
Jun 4, 2019
Merged
refactor(core/presentation): Consolidate Checklist and ChecklistInput components #7077
christopherthielen
merged 2 commits into
spinnaker:master
from
christopherthielen:checklist-input
Jun 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
force-pushed
the
checklist-input
branch
from
June 3, 2019 22:46
4ac3c88
to
6d5c8dd
Compare
|
||
const noop = () => {}; | ||
|
||
fdescribe('<ChecklistInput />', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whops.
christopherthielen
force-pushed
the
checklist-input
branch
from
June 3, 2019 22:48
6d5c8dd
to
266349a
Compare
|
||
const noop = () => {}; | ||
|
||
describe('<ChecklistInput />', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank Justin for these tests
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (spinnaker#7068) e6d1586 feat(core/presentation): support JSX for validationMessage in FormFields (spinnaker#7083) 78a9f72 fix(core): Disable rewriteLinks to allow proper event handling (spinnaker#7064) 3f21c1f feat(executions): Adding redirect for execution without application (spinnaker#7076) f89d97d feat(core/presentation): Add "success" type to ValidationMessage (spinnaker#7082) 4e89a39 refactor(core/presentation): Consolidate Checklist and ChecklistInput components (spinnaker#7077) 9bbc002 feat(core/presentation): Support inline radio buttons (spinnaker#7078) b142789 fix(triggers): Poll on execution id instead of event id (spinnaker#7067) 6af93e3 refactor(pipeline): Pipeline stage execution details to react (spinnaker#7063)
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (spinnaker#7068) 4e89a39 refactor(core/presentation): Consolidate Checklist and ChecklistInput components (spinnaker#7077)
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
8398d77 refactor(*): make accountExtractor return an array of strings (#7068) e6d1586 feat(core/presentation): support JSX for validationMessage in FormFields (#7083) 78a9f72 fix(core): Disable rewriteLinks to allow proper event handling (#7064) 3f21c1f feat(executions): Adding redirect for execution without application (#7076) f89d97d feat(core/presentation): Add "success" type to ValidationMessage (#7082) 4e89a39 refactor(core/presentation): Consolidate Checklist and ChecklistInput components (#7077) 9bbc002 feat(core/presentation): Support inline radio buttons (#7078) b142789 fix(triggers): Poll on execution id instead of event id (#7067) 6af93e3 refactor(pipeline): Pipeline stage execution details to react (#7063)
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates two react components that do basically the same thing.
ChecklistInput
is compatible withFormikFormField
so I used that one. I addedinline
rendering mode and a select/deselect all button from theChecklist
component. I refactored all usages ofChecklist
that I found