Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): link to specific version changelog #8341

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

maggieneterval
Copy link
Contributor

Since this change to spinnaker/buildtool, the OSS release changelog gists have been published with one top-level gist per minor release and individual files for each patch release. Since we can now stably link to each patch release changelog on spinnaker.io, let's point the Help --> Version link there rather than the general Releases page, which just links out ot each individual changelog anyway.

Since [this change](spinnaker/buildtool#48) to spinnaker/buildtool, the OSS release changelog gists have been published with one top-level gist per minor release and individual files for each patch release. Since we can now stably link to each patch release changelog on spinnaker.io, let's point the Help --> Version link there rather than the general Releases page, which just links out ot each individual changelog anyway.
@maggieneterval
Copy link
Contributor Author

It's worth noting that for OSS users, the "What's New" changelog has been broken for the entirety of the 1.20 release, since Halyard continued to supply the file name as changelog.md to settings.js but buildtool began naming each file according to the patch release. I haven't heard any bug reports though, so perhaps this feature isn't getting a ton of use. Since we can now link directly to each release's changelog on spinnaker.io, I would not be opposed to removing the What's New changelog modal if Netflix is not using this either. For now, let's provide post-Halyard users with quick access to the changelog.

Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗 📜 💯

@christopherthielen
Copy link
Contributor

worth noting that netflix uses a custom what's new widget

@maggieneterval
Copy link
Contributor Author

maggieneterval commented Jun 16, 2020

@christopherthielen Good to know; in that case, would you be opposed to me removing the OSS What's New widget altogether?

@christopherthielen
Copy link
Contributor

@maggieneterval I will defer to whatever you think is best.

maggieneterval added a commit to maggieneterval/deck that referenced this pull request Jun 17, 2020
For OSS users, the only purpose of the What's New module was to open a modal to display the most recent changelog gist. Since [this change](spinnaker#8341), we will instead link directly to the changelog gist on spinnaker.io. This prevents Deck from needing to be configured with the ID and name of the gist. In the next commit, we will remove those config fields.
mergify bot added a commit that referenced this pull request Jun 17, 2020
* refactor(core): remove What's New module

For OSS users, the only purpose of the What's New module was to open a modal to display the most recent changelog gist. Since [this change](#8341), we will instead link directly to the changelog gist on spinnaker.io. This prevents Deck from needing to be configured with the ID and name of the gist. In the next commit, we will remove those config fields.

* refactor(core): remove SETTINGS.changelog

Since we can now statically construct a link to the appropriate changelog gist using top-level OSS version only, we no longer need changelog metadata to be supplied as part of Deck's config.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants