-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): link to specific version changelog #8341
Conversation
Since [this change](spinnaker/buildtool#48) to spinnaker/buildtool, the OSS release changelog gists have been published with one top-level gist per minor release and individual files for each patch release. Since we can now stably link to each patch release changelog on spinnaker.io, let's point the Help --> Version link there rather than the general Releases page, which just links out ot each individual changelog anyway.
It's worth noting that for OSS users, the "What's New" changelog has been broken for the entirety of the 1.20 release, since Halyard continued to supply the file name as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔗 📜 💯
worth noting that netflix uses a custom what's new widget |
@christopherthielen Good to know; in that case, would you be opposed to me removing the OSS What's New widget altogether? |
@maggieneterval I will defer to whatever you think is best. |
For OSS users, the only purpose of the What's New module was to open a modal to display the most recent changelog gist. Since [this change](spinnaker#8341), we will instead link directly to the changelog gist on spinnaker.io. This prevents Deck from needing to be configured with the ID and name of the gist. In the next commit, we will remove those config fields.
* refactor(core): remove What's New module For OSS users, the only purpose of the What's New module was to open a modal to display the most recent changelog gist. Since [this change](#8341), we will instead link directly to the changelog gist on spinnaker.io. This prevents Deck from needing to be configured with the ID and name of the gist. In the next commit, we will remove those config fields. * refactor(core): remove SETTINGS.changelog Since we can now statically construct a link to the appropriate changelog gist using top-level OSS version only, we no longer need changelog metadata to be supplied as part of Deck's config. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Since this change to spinnaker/buildtool, the OSS release changelog gists have been published with one top-level gist per minor release and individual files for each patch release. Since we can now stably link to each patch release changelog on spinnaker.io, let's point the Help --> Version link there rather than the general Releases page, which just links out ot each individual changelog anyway.